Closed
Bug 1392822
Opened 7 years ago
Closed 7 years ago
In onboarding tour "Library" section, button is labeled "Show Library in Menu" -- but instead highlights a toolbar button
Categories
(Firefox :: General, defect, P2)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: dholbert, Assigned: Fischer)
References
Details
(Whiteboard: [photon-onboarding])
Attachments
(2 files)
In the 57 onboarding tour, in my main Firefox profile, there is a "Library" subsection, which has a button: "Show Library in Menu" BUT, if I click it, it does not show library in Menu. Instead, it highlights the Library button on my toolbar. This is confusing. (If I remove the library button from my toolbar using Customize Mode, *then* this onboarding-tour-button will highlight the library entry in the hamburger menu. But under the default icon configuration, it highlights a button on the toolbar, not in the menu.)
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(rexboy)
Summary: In onboarding tour "Library" section, button is labeled "Show Library in Menu" -- but library is not in menu → In onboarding tour "Library" section, button is labeled "Show Library in Menu" -- but instead highlights a toolbar button
Updated•7 years ago
|
Whiteboard: [photon-onboarding][triage]
Reporter | ||
Comment 1•7 years ago
|
||
Reporter | ||
Comment 2•7 years ago
|
||
(using needinfo=rexboy to get this on his radar, since I've noticed him help out on other onboarding-tour bugs. Feel free to redirect as-appropriate, though. Thanks!)
Reporter | ||
Comment 3•7 years ago
|
||
FWIW, I'm using Nightly 57.0a1 (2017-08-22) (64-bit) on Ubuntu 17.04 Linux.
Comment 4•7 years ago
|
||
Hi Verdi, the library's button string is incorrect now since we altered the library highlight support... Could you help figure out the right one?
Flags: needinfo?(rexboy) → needinfo?(mverdi)
Updated•7 years ago
|
Flags: qe-verify+
Priority: -- → P2
QA Contact: jwilliams
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
Comment 6•7 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #4) > Hi Verdi, > > the library's button string is incorrect now since we altered the library > highlight support... Could you help figure out the right one? I talked to Michelle and we agreed that "Show Library Menu" is the correct string for the new behavior.
Flags: needinfo?(mverdi)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8901029 -
Flags: review?(rexboy)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Assignee: nobody → fliu
Status: NEW → ASSIGNED
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8901029 [details] Bug 1392822 - change the Library tour action button title to "Show Library Menu", https://reviewboard.mozilla.org/r/172496/#review178346
Attachment #8901029 -
Flags: review?(gasolin) → review+
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8901029 [details] Bug 1392822 - change the Library tour action button title to "Show Library Menu", https://reviewboard.mozilla.org/r/172496/#review178348 ::: commit-message-2306e:1 (Diff revision 3) > +Bug 1392822 - In onboarding tour "Library" section, button is labeled "Show Library in Menu" -- but instead highlights a toolbar button, r?gasolin please rename the bug commit to reflect the actual change, such as "Bug 1392822 - change button description to Show library menu"
Comment hidden (mozreview-request) |
Assignee | ||
Comment 13•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8901029 [details] Bug 1392822 - change the Library tour action button title to "Show Library Menu", https://reviewboard.mozilla.org/r/172496/#review178348 > please rename the bug commit to reflect the actual change, such as "Bug 1392822 - change button description to Show library menu" Updated, thanks
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 14•7 years ago
|
||
Pushed by flin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26922f626539 change the Library tour action button title to "Show Library Menu", r=gasolin
Keywords: checkin-needed
Comment 16•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/26922f626539
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 18•7 years ago
|
||
I can confirm the intended behavior is respected on beta. I verified using Fx 57.0b7 on Windows 10 x64, Ubuntu 14.04 LTS and macOS X 10.12.6.
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•