1392868 - All Linux builds are going to permafail when EARLY_BETA_OR_EARLIER is reset for Gecko 57 on Beta

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Broken Linux builds halfway through the Gecko 57 Beta cycle.

Bisection on Try confirms that this was caused by revision db36870cee64 specifically. Interestingly, this failure only occurs when EARLY_BETA_OR_EARLIER gets reset in the simulation runs (which matches what we do roughly midway through the Beta cycle).

Patches used to reproduce:
https://hg.mozilla.org/try/rev/fcc3b10a200f90c59bb17be9b93a39de4fa9c0cb
https://hg.mozilla.org/try/rev/1438349ad50e67a825f427754eaccfc60f861ab3
https://hg.mozilla.org/try/rev/e99b9c1810d9624b644ad1d67439f7eae985f667

https://treeherder.mozilla.org/logviewer.html#?job_id=125036424&repo=try

/home/worker/workspace/build/src/xpcom/threads/SchedulerGroup.cpp:89:1: error: 'void {anonymous}::AutoCollectVsyncTelemetry::CollectTelemetry()' defined but not used [-Werror=unused-function]

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1392868 - Completely remove AutoCollectVsyncTelemetry on late beta.

The class, in practice, was already doing nothing in that case, but with
it being half #ifdef'ed on EARLY_BETA_OR_EARLIER, that led to build
failures for unused code on late beta. Just remove the class completely
on late beta.

Review commit: https://reviewboard.mozilla.org/r/171418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171418/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8900075 [details]
Bug 1392868 - Completely remove AutoCollectVsyncTelemetry on late beta.

https://reviewboard.mozilla.org/r/171418/#review176766

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbb3f631b3de
Completely remove AutoCollectVsyncTelemetry on late beta. r=froydnj

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cbb3f631b3de

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This is fixed, no need to track it.