Closed Bug 1392913 Opened 2 years ago Closed 2 years ago

Remove updatev2.manifest support and other code that is no longer necessary for backwards compatibility after the next watershed.

Categories

(Toolkit :: Application Update, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: rstrong, Assigned: rstrong)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

It isn't clear yet at this time when the next watershed will be though it was planned for 56 so when this is possible isn't entirely clear yet.

The following will no longer be needed after the watershed
updatev2.manifest support
removal of the precomplete file in the root of the OS Xapplication bundle - bug 1071465
distribution directory migration on OS X -  bug 1068439

The test changes in the bugs referenced will also need to reverted.
Attached patch patch rev2 (obsolete) — Splinter Review
Pushed to oak
https://treeherder.mozilla.org/#/jobs?repo=oak&tochange=8de636405feaf9992512c5e5a672991390ed8c35&fromchange=8de636405feaf9992512c5e5a672991390ed8c35

I went ahead and pushed this to oak in case the mar generation has issues with dealing with a removed-files.in file that doesn't contain any instructions.
Attachment #8911529 - Attachment is obsolete: true
Attached patch patch rev2Splinter Review
Comment change
Attachment #8911626 - Attachment is obsolete: true
Comment on attachment 8911629 [details] [diff] [review]
patch rev2

Tested updates on oak and all looks good.
Attachment #8911629 - Flags: review?(mhowell)
Attachment #8911629 - Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/255fcb2c2622
Remove updatev2.manifest support and other code that is no longer necessary for backwards compatibility after the next watershed. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/255fcb2c2622
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Tom, with the update watershed you should be able to remove all of the entries in Thunderbird's removed-files.in file as was done in this bug's patch for Firefox.
https://dxr.mozilla.org/comm-central/source/mail/installer/removed-files.in
Flags: needinfo?(mozilla)
Will this code be needed ESR 59?
This patch which removes the updatev2.manifest support will be in ESR 59 since it landed for 58 and 56.x is an update watershed. When the removed-files.in changes are made can happen anytime after the update watershed since they are there to support updating from earlier versions.
Flags: needinfo?(mozilla) → needinfo?(philipp)
rstrong: it looks like removed-files.in is no longer needed.  Is there a ticket tracked to tear that whole thing out?  Can it not, in fact, be done yet for some other reason?
Flags: needinfo?(robert.strong.bugs)
Not at all. This is needed for one-off removals which can be 3rd party files that are dropped into the install dir, files accidentally added after the generation of the precomplete file (happened recently with some OS X signing changes), files in the distribution directory, and probably other cases as well. I don't see this file ever being removed due to these reasons.
Flags: needinfo?(robert.strong.bugs)
Flags: needinfo?(philipp)
You need to log in before you can comment on or make changes to this bug.