Delete about:sessionrestore & about:welcomeback from about:about

VERIFIED FIXED in Firefox 57

Status

()

Firefox
General
VERIFIED FIXED
3 months ago
2 months ago

People

(Reporter: Virtual, Assigned: Steve Armand, Mentored)

Tracking

({good-first-bug, nightly-community, ux-consistency})

Trunk
Firefox 57
good-first-bug, nightly-community, ux-consistency
Points:
---

Firefox Tracking Flags

(firefox57 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Delete about:sessionrestore & about:welcomeback from about:about, as they're only used internally and not useful otherwise.
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant

Updated

3 months ago
Keywords: nightly-community, ux-consistency → ux-minimalism
OS: Windows 7 → All
Hardware: x86_64 → All
Whiteboard: [good first bug]
Keywords: nightly-community
Yang: Note that generally, we expect a good first bug to have (a) a mentor and (b) a description of how to fix the bug -- and "good first bug" is a keyword rather than whiteboard tag now.

I guess I'll add myself as a mentor. Fixing this bug requires adding the "HIDE_FROM_ABOUTABOUT" flag to the "sessionstore" and "welcomeback" entries in the list in https://searchfox.org/mozilla-central/source/browser/components/about/AboutRedirector.cpp .
Mentor: gijskruitbosch+bugs@gmail.com
Keywords: ux-minimalism → good-first-bug
Whiteboard: [good first bug]
Comment hidden (mozreview-request)
(Assignee)

Comment 3

3 months ago
I've added the HIDE_FROM_ABOUTABOUT flag to the 2 entries in browser/components/about/AboutRedirector.cpp as suggested.
Assignee: nobody → stevea1
Status: NEW → ASSIGNED

Comment 4

3 months ago
mozreview-review
Comment on attachment 8903988 [details]
Bug 1392981 - Delete about:sessionrestore & about:welcomeback from about:about.

https://reviewboard.mozilla.org/r/175740/#review180784

Looks good, thanks!
Attachment #8903988 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 5

3 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d225dbb6b59f
Delete about:sessionrestore & about:welcomeback from about:about. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/d225dbb6b59f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-09-04), so I'm marking this bug as VERIFIED. Thanks.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Keywords: ux-consistency
You need to log in before you can comment on or make changes to this bug.