Closed
Bug 1392981
Opened 7 years ago
Closed 7 years ago
Delete about:sessionrestore & about:welcomeback from about:about
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: Virtual, Assigned: stevea1, Mentored)
Details
(Keywords: good-first-bug, nightly-community, ux-consistency)
Attachments
(1 file)
Delete about:sessionrestore & about:welcomeback from about:about, as they're only used internally and not useful otherwise.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
OS: Windows 7 → All
Hardware: x86_64 → All
Whiteboard: [good first bug]
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Keywords: nightly-community
Comment 1•7 years ago
|
||
Yang: Note that generally, we expect a good first bug to have (a) a mentor and (b) a description of how to fix the bug -- and "good first bug" is a keyword rather than whiteboard tag now. I guess I'll add myself as a mentor. Fixing this bug requires adding the "HIDE_FROM_ABOUTABOUT" flag to the "sessionstore" and "welcomeback" entries in the list in https://searchfox.org/mozilla-central/source/browser/components/about/AboutRedirector.cpp .
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
I've added the HIDE_FROM_ABOUTABOUT flag to the 2 entries in browser/components/about/AboutRedirector.cpp as suggested.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Assignee: nobody → stevea1
Status: NEW → ASSIGNED
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8903988 [details] Bug 1392981 - Delete about:sessionrestore & about:welcomeback from about:about. https://reviewboard.mozilla.org/r/175740/#review180784 Looks good, thanks!
Attachment #8903988 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d225dbb6b59f Delete about:sessionrestore & about:welcomeback from about:about. r=Gijs
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d225dbb6b59f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 7•7 years ago
|
||
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-09-04), so I'm marking this bug as VERIFIED. Thanks.
You need to log in
before you can comment on or make changes to this bug.
Description
•