1392996 - view-source appearance tweaks for mobile

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Djfe]

User Agent: Mozilla/5.0 (Android 7.0; Mobile; rv:55.0) Gecko/55.0 Firefox/55.0
Build ID: 20170815231002

Steps to reproduce:

I opened view-source:url for some url


Actual results:

it didn't wrap lines and I had to knew about "view-source:" and enter it manually


Expected results:

it would be nice, if an option "view source code" would be available from the page options, that opens the source code in a new tab.
it should wrap long lines, so that it is readable. (opposite default value for the already existing config)

and one last thing:
the line numbers are a bit small and not very contrasty, which makes them hard to read in sun-light

Comment 1

[Jan Henning [:JanH]]

Bug 1389289, although that in turn is blocked by bug 1251854, because the context menu that allows toggling word wrapping, syntax highlighting and the like is currently preventing any text selection.

Comment 2

[Djfe]

Good to know, you're working on the text selection, looking forward to it :)

view_source.wrap_long_lines should be set to true by default IMO (so that you can disable wrapping with the new context menu) and the line numbers (on the left) should have more contrast

should we reopen this bug, or should I add this to the comments of the other one?

Comment 3

[Jan Henning [:JanH]]

Hmm yes, best to reopen this to track just the additional tweaks for mobile.

Comment 4

[Jan Henning [:JanH]]

Turning word wrapping on seems to subject the page to font inflation, because the line numbers suddenly appear much smaller than the rest of the source text. I guess that also explains your comment that "the line numbers are a bit small".

With any luck, changing the HTML markup powering the source display to include the appropriate <meta> viewport tag, using either width=device-width or else initial-scale=1.0, might be enough to fix this.

Comment 5

[Jan Henning [:JanH]]

Attachment: Bug 1392996 - Part 1 - Add meta viewport tag to view-source document.

Adding <meta name="viewport" content="width=device-width"/> to the view-source
document achieves two things when used in a mobile browser, such as Fennec:
1. When word-wrapping is turned off, the page displays at a more readable
   initial zoom level.
2. As of now, font inflation (when enabled) kicks in on the document when word-
   wrapping is turned on, which leads to the line numbers appearing in a
   noticeably smaller font size than the rest of the page.
   Adding the above meta viewport header marks the document as "mobile-friendly"
   and suppresses font inflation, which means that line numbers will appear
   normally even with word-wrapping enabled.

getMathMLSelection() in browser-content.js isn't actually used in Fennec at the
moment, but for consistency we add the meta viewport tag there as well.

Review commit: https://reviewboard.mozilla.org/r/216120/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216120/

Comment 6

[Jan Henning [:JanH]]

Attachment: Bug 1392996 - Part 2 - Enable view-source word-wrapping by default in Fennec.

Review commit: https://reviewboard.mozilla.org/r/216122/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216122/

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8946134 [details]
Bug 1392996 - Part 1 - Add meta viewport tag to view-source document.

I think Henri should take a look at this.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8946135 [details]
Bug 1392996 - Part 2 - Enable view-source word-wrapping by default in Fennec.

https://reviewboard.mozilla.org/r/216122/#review222532

Comment 9

[Henri Sivonen (:hsivonen)]

Comment on attachment 8946134 [details]
Bug 1392996 - Part 1 - Add meta viewport tag to view-source document.

https://reviewboard.mozilla.org/r/216120/#review223532

Thanks and sorry about the delay.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fce65dcf661b
Part 1 - Add meta viewport tag to view-source document. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/11e5e7079111
Part 2 - Enable view-source word-wrapping by default in Fennec. r=snorp

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fce65dcf661b
https://hg.mozilla.org/mozilla-central/rev/11e5e7079111