1392998 - Remove DevTools hotreload feature

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Cf my message posted on devtools mailing lit: https://groups.google.com/d/msg/mozilla.dev.developer-tools/HGpjIQuRJGg/J6Gv1PYJAAAJ

While waiting some more time to let others reply, the response has been positive so far, so I'll get started on a patch to remove the devtools.loader.hotreload feature.

Comment 1

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f9cd67ac2e1c7ee3ae370c2e4233ff50b15b8d4

Comment 2

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=692710a027f64396d1ad3e900b251f9c8df67cfd

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1392998 - remove devtools hotreload feature;

Review commit: https://reviewboard.mozilla.org/r/172256/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172256/

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1392998 - remove irrelevant documentation files for react/redux tips;

Review commit: https://reviewboard.mozilla.org/r/172258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172258/

Comment 5

[Julian Descottes [:jdescottes]]

Only got positive replies on the mailing list so far, so let's move on with this.

Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d47bf92f7e0e16cd4993ff49db91f2e1d09ddae

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8900818 [details]
Bug 1392998 - remove devtools hotreload feature;

https://reviewboard.mozilla.org/r/172256/#review177530

LGTM!

Comment 7

[Soledad Penades [:sole] [:spenades]]

Comment on attachment 8900819 [details]
Bug 1392998 - remove irrelevant documentation files for react/redux tips;

https://reviewboard.mozilla.org/r/172258/#review177536

You will also need to delete the mention to the file from http://searchfox.org/mozilla-central/source/devtools/docs/SUMMARY.md - other than that, nice!

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8900819 [details]
Bug 1392998 - remove irrelevant documentation files for react/redux tips;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172258/diff/1-2/

Comment 9

[Julian Descottes [:jdescottes]]

Comment on attachment 8900818 [details]
Bug 1392998 - remove devtools hotreload feature;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172256/diff/1-2/

Comment 10

[Julian Descottes [:jdescottes]]

Comment on attachment 8900819 [details]
Bug 1392998 - remove irrelevant documentation files for react/redux tips;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172258/diff/2-3/

Comment 11

[Julian Descottes [:jdescottes]]

Comment on attachment 8900819 [details]
Bug 1392998 - remove irrelevant documentation files for react/redux tips;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172258/diff/3-4/

Comment 12

[Julian Descottes [:jdescottes]]

Thanks for the reviews! 

(In reply to Soledad Penades [:sole] [:spenades] from comment #7)
> Comment on attachment 8900819 [details]
> Bug 1392998 - remove irrelevant documentation files for react/redux tips;
> 
> https://reviewboard.mozilla.org/r/172258/#review177536
> 
> You will also need to delete the mention to the file from
> http://searchfox.org/mozilla-central/source/devtools/docs/SUMMARY.md - other
> than that, nice!

Thanks, I assumed the summary was automatically generated, sorry :/ 
Moved all the documentation related changes to this second changeset.

Comment 13

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 3933aabc8202 -d 9058d354635f: rebasing 416836:3933aabc8202 "Bug 1392998 - remove devtools hotreload feature;r=bgrins"
local [dest] changed devtools/client/shared/file-watcher-worker.js which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
merging devtools/client/shared/vendor/moz.build
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 14

[Julian Descottes [:jdescottes]]

Comment on attachment 8900818 [details]
Bug 1392998 - remove devtools hotreload feature;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172256/diff/2-3/

Comment 15

[Julian Descottes [:jdescottes]]

Comment on attachment 8900819 [details]
Bug 1392998 - remove irrelevant documentation files for react/redux tips;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172258/diff/4-5/

Comment 16

[Julian Descottes [:jdescottes]]

rebased. try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7658da53205c62b97a36ef1b09102cae2dd51bb

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cf7feec9985
remove devtools hotreload feature;r=bgrins
https://hg.mozilla.org/integration/autoland/rev/19738c33b0f5
remove irrelevant documentation files for react/redux tips;r=sole

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5cf7feec9985
https://hg.mozilla.org/mozilla-central/rev/19738c33b0f5