Closed Bug 1393004 Opened 7 years ago Closed 6 years ago

Perma false-positive ValueError: badly formed hexadecimal UUID string

Categories

(Testing :: web-platform-tests, defect)

defect
Not set
normal

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: KWierso)

Details

Attachments

(1 file)

Filed by: archaeopteryx [at] coole-files.de

https://treeherder.mozilla.org/logviewer.html#?job_id=125141039&repo=autoland

https://queue.taskcluster.net/v1/task/QroqHMRSTPyo9SifkVIk0Q/runs/0/artifacts/public/logs/live_backing.log

04:40:08     INFO - TEST-START | /content-security-policy/script-src/script-src-multiple-policies-one-using-hashing-algorithms.html
04:40:08     INFO - PID 1608 | 1503488408144	Marionette	DEBUG	Register listener.js for window 2147483686
04:40:08  WARNING - Traceback (most recent call last):
04:40:08  WARNING -   File "/Users/cltbld/tasks/task_1503488219/build/tests/web-platform/tests/tools/wptserve/wptserve/handlers.py", line 251, in __call__
04:40:08  WARNING -     rv = self.func(request, response)
04:40:08  WARNING -   File "/Users/cltbld/tasks/task_1503488219/build/tests/web-platform/tests/content-security-policy/support/report.py", line 14, in main
04:40:08  WARNING -     value = request.server.stash.take(key=key)
04:40:08  WARNING -   File "/Users/cltbld/tasks/task_1503488219/build/tests/web-platform/tests/tools/wptserve/wptserve/stash.py", line 131, in take
04:40:08  WARNING -     internal_key = self._wrap_key(key, path)
04:40:08  WARNING -   File "/Users/cltbld/tasks/task_1503488219/build/tests/web-platform/tests/tools/wptserve/wptserve/stash.py", line 106, in _wrap_key
04:40:08  WARNING -     return (str(path), str(uuid.UUID(key)))
04:40:08  WARNING -   File "/tools/python27/lib/python2.7/uuid.py", line 134, in __init__
04:40:08  WARNING -     raise ValueError('badly formed hexadecimal UUID string')
04:40:08  WARNING - ValueError: badly formed hexadecimal UUID string
Another frequent false positive. Again, any help you can provide would be great, James :)
Flags: needinfo?(james)
I guess this got fixed, or at least  people stopped classifying thigs as this.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(james)
Resolution: --- → WORKSFORME
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=179827771&repo=mozilla-inbound&lineNumber=1776

[task 2018-05-23T14:29:05.357Z] 14:29:05     INFO - TEST-START | /content-security-policy/navigate-to/form-action/form-action-blocks-navigate-to-allows.html
[task 2018-05-23T14:29:05.567Z] 14:29:05     INFO - PID 2196 | JavaScript error: http://web-platform.test:8000/content-security-policy/navigate-to/support/form_action_navigation.sub.html?csp=navigate-to%20%27self%27%3B%20form-action%20%27none%27%3B&action=post_message_to_frame_owner.html, line 31: :
[task 2018-05-23T14:29:05.584Z] 14:29:05  WARNING - Traceback (most recent call last):
[task 2018-05-23T14:29:05.584Z] 14:29:05  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/handlers.py", line 262, in __call__
[task 2018-05-23T14:29:05.588Z] 14:29:05  WARNING -     rv = self.func(request, response)
[task 2018-05-23T14:29:05.588Z] 14:29:05  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/content-security-policy/support/report.py", line 50, in main
[task 2018-05-23T14:29:05.588Z] 14:29:05  WARNING -     request.server.stash.take(key=key)
[task 2018-05-23T14:29:05.588Z] 14:29:05  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/stash.py", line 152, in take
[task 2018-05-23T14:29:05.588Z] 14:29:05  WARNING -     internal_key = self._wrap_key(key, path)
[task 2018-05-23T14:29:05.588Z] 14:29:05  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/stash.py", line 127, in _wrap_key
[task 2018-05-23T14:29:05.588Z] 14:29:05  WARNING -     return (str(path), str(uuid.UUID(key)))
[task 2018-05-23T14:29:05.588Z] 14:29:05  WARNING -   File "/usr/lib/python2.7/uuid.py", line 136, in __init__
[task 2018-05-23T14:29:05.588Z] 14:29:05  WARNING -     raise ValueError('badly formed hexadecimal UUID string')
[task 2018-05-23T14:29:05.588Z] 14:29:05  WARNING - ValueError: badly formed hexadecimal UUID string
[task 2018-05-23T14:29:05.588Z] 14:29:05  WARNING - 
[task 2018-05-23T14:29:05.620Z] 14:29:05     INFO - .
[task 2018-05-23T14:29:05.621Z] 14:29:05     INFO - TEST-OK | /content-security-policy/navigate-to/form-action/form-action-blocks-navigate-to-allows.html | took 266ms
[task 2018-05-23T14:29:05.622Z] 14:29:05     INFO - TEST-START | /content-security-policy/navigate-to/form-action/form-action-blocks-navigate-to-blocks.html
[task 2018-05-23T14:29:05.820Z] 14:29:05     INFO - PID 2196 | JavaScript error: http://web-platform.test:8000/content-security-policy/navigate-to/support/form_action_navigation.sub.html?csp=navigate-to%20%27none%27%3B%20form-action%20%27none%27%3B&action=post_message_to_frame_owner.html, line 31: :
[task 2018-05-23T14:29:05.825Z] 14:29:05  WARNING - Traceback (most recent call last):
[task 2018-05-23T14:29:05.825Z] 14:29:05  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/handlers.py", line 262, in __call__
[task 2018-05-23T14:29:05.825Z] 14:29:05  WARNING -     rv = self.func(request, response)
[task 2018-05-23T14:29:05.825Z] 14:29:05  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/content-security-policy/support/report.py", line 50, in main
[task 2018-05-23T14:29:05.826Z] 14:29:05  WARNING -     request.server.stash.take(key=key)
[task 2018-05-23T14:29:05.828Z] 14:29:05  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/stash.py", line 152, in take
[task 2018-05-23T14:29:05.828Z] 14:29:05  WARNING -     internal_key = self._wrap_key(key, path)
[task 2018-05-23T14:29:05.829Z] 14:29:05  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/stash.py", line 127, in _wrap_key
[task 2018-05-23T14:29:05.830Z] 14:29:05  WARNING -     return (str(path), str(uuid.UUID(key)))
[task 2018-05-23T14:29:05.831Z] 14:29:05  WARNING -   File "/usr/lib/python2.7/uuid.py", line 136, in __init__
[task 2018-05-23T14:29:05.831Z] 14:29:05  WARNING -     raise ValueError('badly formed hexadecimal UUID string')
[task 2018-05-23T14:29:05.832Z] 14:29:05  WARNING - ValueError: badly formed hexadecimal UUID string
[task 2018-05-23T14:29:05.832Z] 14:29:05  WARNING - 
[task 2018-05-23T14:29:05.886Z] 14:29:05     INFO - .
[task 2018-05-23T14:29:05.886Z] 14:29:05     INFO - TEST-OK | /content-security-policy/navigate-to/form-action/form-action-blocks-navigate-to-blocks.html | took 266ms
[task 2018-05-23T14:29:05.911Z] 14:29:05     INFO - PID 2196 | 1527085745909	Marionette	INFO	Stopped listening on port 2828
[task 2018-05-23T14:29:06.089Z] 14:29:06     INFO - PID 2196 | *** UTM:SVC TimerManager:registerTimer called after profile-before-change notification. Ignoring timer registration for id: telemetry_modules_ping
[task 2018-05-23T14:29:06.409Z] 14:29:06     INFO - Browser exited with return code 0
[task 2018-05-23T14:29:06.410Z] 14:29:06  WARNING - u'runner_teardown': ()
[task 2018-05-23T14:29:06.426Z] 14:29:06     INFO - Setting up ssl
[task 2018-05-23T14:29:06.454Z] 14:29:06     INFO - certutil | 
[task 2018-05-23T14:29:06.490Z] 14:29:06     INFO - certutil | 
[task 2018-05-23T14:29:06.511Z] 14:29:06     INFO - certutil | 
[task 2018-05-23T14:29:06.511Z] 14:29:06     INFO - Certificate Nickname                                         Trust Attributes
[task 2018-05-23T14:29:06.512Z] 14:29:06     INFO -                                                              SSL,S/MIME,JAR/XPI
[task 2018-05-23T14:29:06.512Z] 14:29:06     INFO - 
[task 2018-05-23T14:29:06.512Z] 14:29:06     INFO - web-platform-tests                                           CT,, 
[task 2018-05-23T14:29:06.512Z] 14:29:06     INFO - 
[task 2018-05-23T14:29:06.529Z] 14:29:06     INFO - Application command: /builds/worker/workspace/build/application/firefox/firefox --marionette about:blank -profile /tmp/tmpVU2ULD.mozrunner
[task 2018-05-23T14:29:06.545Z] 14:29:06     INFO - Starting runner
[task 2018-05-23T14:29:06.808Z] 14:29:06     INFO - PID 2374 | 1527085746802	addons.xpi-utils	WARN	Error: Synchronously loading the add-ons database (resource://gre/modules/addons/XPIDatabase.jsm:1386:17) JS Stack trace: syncLoadDB@XPIDatabase.jsm:1386:17
[task 2018-05-23T14:29:06.808Z] 14:29:06     INFO - PID 2374 | checkForChanges@XPIProvider.jsm:2775:9
[task 2018-05-23T14:29:06.809Z] 14:29:06     INFO - PID 2374 | startup@XPIProvider.jsm:2324:25
[task 2018-05-23T14:29:06.809Z] 14:29:06     INFO - PID 2374 | callProvider@AddonManager.jsm:205:12
[task 2018-05-23T14:29:06.809Z] 14:29:06     INFO - PID 2374 | _startProvider@AddonManager.jsm:653:5
[task 2018-05-23T14:29:06.810Z] 14:29:06     INFO - PID 2374 | startup@AddonManager.jsm:812:9
[task 2018-05-23T14:29:06.811Z] 14:29:06     INFO - PID 2374 | startup@AddonManager.jsm:2864:5
[task 2018-05-23T14:29:06.811Z] 14:29:06     INFO - PID 2374 | observe@addonManager.js:66:9
[task 2018-05-23T14:29:08.903Z] 14:29:08     INFO - PID 2374 | 1527085748895	Marionette	INFO	Listening on port 2828
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Summary: Intermittent ValueError: badly formed hexadecimal UUID string → Intermittent false-positive ValueError: badly formed hexadecimal UUID string DON'T USE
Summary: Intermittent false-positive ValueError: badly formed hexadecimal UUID string DON'T USE → Perma false-positive ValueError: badly formed hexadecimal UUID string DON'T USE
In the last 7 days there are 35 pins on this bug. Please don't use this bug for classification.
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → INCOMPLETE
Umm, no.

How frequently it is starred means *nothing*, because it is a permanent false positive. Every single time that we run content-security-policy/navigate-to/form-action/form-action-blocks-navigate-to-allows.html and content-security-policy/navigate-to/form-action/form-action-blocks-navigate-to-blocks.html and content-security-policy/navigate-to/spv-only-sent-to-initiator.html, because of a bug in wptserve/stash.py they cause a ValueError: badly formed hexadecimal UUID string and a traceback from Python's uuid.py.

Either they are doing nothing wrong, and stash.py should eat that error rather than letting it be propagated, or they are doing something wrong and they should be fixed *and* stash.py should cause a test doing whatever they are doing wrong to fail.
Status: RESOLVED → REOPENED
Priority: P5 → --
Resolution: INCOMPLETE → ---
Summary: Perma false-positive ValueError: badly formed hexadecimal UUID string DON'T USE → Perma false-positive ValueError: badly formed hexadecimal UUID string
Version: Version 3 → unspecified
Neither test file was picking up the pipes correctly due to file names, and form-action-blocks-navigate-to-allows was just using the string "dummy" instead of an actual dummy uuid. This patch fixes that.
Assignee: nobody → wkocher
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/dda13ad0cdee
Make sure wpt pipes are used in form-action-blocks-navigate-to-allows and spv-only-sent-to-initiator r=jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13918 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Backed out changeset dda13ad0cdee (bug 1393004) for failing TV tests on spv-only-sent-to-initiator.sub.html CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/08b1577d337fd1e028d0be9b2cf0e62aeac9aba8

Failed push: https://hg.mozilla.org/integration/autoland/rev/dda13ad0cdeeaa459b1d9840714ca358eb107277

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=209800684&repo=autoland

These TV failures turned in to Wpt9 failures: https://treeherder.mozilla.org/logviewer.html#?job_id=209797614&repo=autoland

:KWierso could you please take a look?
Flags: needinfo?(wkocher)
Upstream PR was closed without merging
Helps if I actually committed the expectation file's renaming when I renamed the test file...
Flags: needinfo?(wkocher)
Pushed by wkocher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9b6e7b83b97
Make sure wpt pipes are used in form-action-blocks-navigate-to-allows and spv-only-sent-to-initiator r=jgraham
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/a9b6e7b83b97
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: