Closed
Bug 1393015
Opened 9 years ago
Closed 9 years ago
Disable KillHard timeout when running reftests
Categories
(Testing :: Reftest, defect)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
The dom.ipc.tabs.shutdownTimeoutSecs pref is set to 5 by default in production, and controls the number of seconds the content process is allowed when shutting down. This pref is set to 0 in various test harnesses, including addon-sdk [1] and mochitests [2], which disable the timeout when running those tests.
We should also disable it for reftests. In particular, this blocks landing bug 1368120 because for some reason that bug increases the content process load just enough to trigger the timeout intermittently. This is not a real perf regression because the bug in question is fiddling with webrender stuff which isn't enabled by default yet (we will ensure no perf regression when we do enable it by default).
[1] http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/addon-sdk/source/test/preferences/test.json#39
[2] http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/testing/profiles/prefs_general.js#345
| Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8900243 -
Flags: review?(bugs)
Updated•9 years ago
|
Attachment #8900243 -
Flags: review?(bugs) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed61f3a117e5
Disable KillHard timeout for reftests. r=smaug
Comment 3•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•