Closed
Bug 1393021
Opened 7 years ago
Closed 6 years ago
Drag and drop bookmarks doesn't work properly when copying from one instance of the browser to another
Categories
(Firefox :: Bookmarks & History, defect, P3)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
DUPLICATE
of bug 1386513
Tracking | Status | |
---|---|---|
firefox57 | --- | affected |
People
(Reporter: standard8, Unassigned)
Details
(Whiteboard: [fxsearch])
STR: 1) Open two instances of Firefox with different profiles 2) Open the Library window in both of those and look at a bookmarks folder 3) Drag a bookmark from one instance to the other. Expected Result -> The bookmark is copied without any issues. Actual Results -> The copy doesn't happen. Errors on the console: Error: Cannot move a non-existent item Stack trace: execute@resource://gre/modules/PlacesTransactions.jsm:1252:13 Async*transact/promise<@resource://gre/modules/PlacesTransactions.jsm:546:26 async*enqueue/promise<@resource://gre/modules/PlacesTransactions.jsm:472:58 promise callback*enqueue@resource://gre/modules/PlacesTransactions.jsm:472:19 transact@resource://gre/modules/PlacesTransactions.jsm:543:19 transact@resource://gre/modules/PlacesTransactions.jsm:231:16 batch/<@resource://gre/modules/PlacesTransactions.jsm:332:19 async*batch/<@resource://gre/modules/PlacesTransactions.jsm:566:20 async*enqueue/promise<@resource://gre/modules/PlacesTransactions.jsm:472:58 promise callback*enqueue@resource://gre/modules/PlacesTransactions.jsm:472:19 batch@resource://gre/modules/PlacesTransactions.jsm:561:12 batch@resource://gre/modules/PlacesTransactions.jsm:329:14 onDrop@chrome://browser/content/places/controller.js:1643:13 async*PTV_drop@chrome://browser/content/places/treeView.js:1456:7 Console.jsm:505
Reporter | ||
Comment 1•7 years ago
|
||
Now I've looked at the code and played around a bit more, I don't think there is a regression here - I think it is an existing issue, that just gets hidden at times. It seems that the drag and drop code (pre or post async transactions) doesn't really handle dropping of "text/x-moz-place" from *outside* the instance we're running in. It generally assumes we're either moving or copying a bookmark, and as a result it fails if the bookmark doesn't exist within the instance already.
No longer blocks: PlacesAsyncTransact, 1071513
Component: Places → Bookmarks & History
Keywords: regression,
reproducible
Priority: P2 → P3
Product: Toolkit → Firefox
Summary: Drag and drop bookmarks fails when copying from one instance of the browser to another with async Transactions enabled → Drag and drop bookmarks doesn't work properly when copying from one instance of the browser to another
Reporter | ||
Comment 2•6 years ago
|
||
This was fixed by bug 1386513.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•