1393037 - [traceback] ValueError on raw_crash.OOMAllocationSize conversion

Status: RESOLVED FIXED

(Socorro :: Processor, task, P3)

Description

[Peter Bengtsson [:peterbe]]

See https://sentry.prod.mozaws.net/operations/socorro-prod/issues/643312/

Sentry is failing to display the raw error but the failure is in converting
'24178AvailablePhysicalMemory586522624AvailablePageFile5410816ContentSandboxLevel=1' to an int here https://github.com/mozilla-services/socorro/blob/6c2b5bb24b4609dcef87b349e209ba2d8c937be5/socorro/processor/signature_utilities.py#L517

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Traceback:

"""
ValueError: invalid literal for int() with base 10: '24178AvailablePhysicalMemory586522624AvailablePageFile5410816ContentSandboxLevel=1'
  File "socorro/lib/transform_rules.py", line 147, in action
    return self._action(*args, **kwargs)
  File "socorro/processor/signature_utilities.py", line 517, in _action
    size = int(raw_crash['OOMAllocationSize'])
"""

There's only been one instance of this so far.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Saw this on -stage: https://sentry.prod.mozaws.net/operations/socorro-stage/issues/645543/

In total, there are 3 events of this now.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Still only 3 events. I'm making this a P3.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is a good first bug.

To fix this, we need to fix the code in signature_utilities.py to be more defensive. If it gets a bogus value for raw_crash['OOMAllocationSize'], it should skip merrily past it instead of throwing an exception.

Comment 5

[Videet Singhai]

Hello I can take this bug

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Videet: Do you have a local development environment set up? If not, read through:

https://socorro.readthedocs.io/en/latest/gettingstarted.html

to get one working. You'll need a local development environment working in order to work on Socorro changes.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Issei: Would you want to work on this one?

Comment 8

[Issei Horie [:is2ei]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #7)
> Issei: Would you want to work on this one?

Ok! I will work on this issue.

Comment 9

[Issei Horie [:is2ei]]

Attachment: GitHub PR

I created PR. Could you check it, please?

Comment 10

[Issei Horie [:is2ei]]

BTW, I have a question.
I couldn't access to these URLs.
https://sentry.prod.mozaws.net/operations/socorro-prod/issues/643312/
https://sentry.prod.mozaws.net/operations/socorro-stage/issues/645543/

How could I see the pages?

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/44f8a5fa437240a9d3149f236545d57c72c63d10
Bug 1393037 Catch ValueError on raw_crash.OOMAllocationSize conversion

https://github.com/mozilla-services/socorro/commit/1b3ed0854e791df66b1007e9ca948f89a8453226
Merge pull request #4495 from is2ei/bug-1393037

Bug 1393037 Catch ValueError on raw_crash.OOMAllocationSize conversion

Comment 12

[Will Kahn-Greene [:willkg] ET needinfo? me]

Issei: Those are in our Sentry instance and not publicly available. I can copy/paste data from Sentry error reports that is not sensitive like I did in this case and I can answer questions, but can't give access to others. Sorry!

Comment 13

[Will Kahn-Greene [:willkg] ET needinfo? me]

I just landed the fix for this, so I'm marking it FIXED.

Thank you, Issei!