Closed
Bug 1393053
Opened 8 years ago
Closed 8 years ago
Remove an unnecessary call to GetPrototypeFromConstructor for wrapped promise constructors
Categories
(Core :: JavaScript: Standard Library, enhancement)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
3.33 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
We don't need to go through GetPrototypeFromConstructor for wrapped Promise constructors (http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/js/src/builtin/Promise.cpp#1377), instead we can simply get %PromisePrototype% from the target compartment.
---
There are some open GetPrototypeFromConstructor spec-compliance bugs (bug 1288457, bug 1317416), but before attempting to fix those, we should revisit the existing GetPrototypeFromConstructor callers to get a better picture which changes are necessary for bug 1288457 and bug 1317416.
|
Assignee | |
Comment 1•8 years ago
|
||
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8900281 [details] [diff] [review]
bug1393053.patch
Review of attachment 8900281 [details] [diff] [review]:
-----------------------------------------------------------------
Ah, much nicer - thanks!
Attachment #8900281 -
Flags: review?(till) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9bdad241dea901c0008faec4df1065f2f85edde9
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e63b09da86eb
Directly get built-in %PromisePrototype% instead of going through GetPrototypeFromConstructor. r=till
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•