1393076 - firefox-55.0.2/security/nss/cmd/libpkix/pkix/top/test_policychecker.c:78: bad conditional ?

Status: NEW

(NSS :: Libraries, defect, P3)

Description

[David Binderman]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170613080647

Steps to reproduce:

firefox-55.0.2/security/nss/cmd/libpkix/pkix/top/test_policychecker.c:78]: (warning) Logical disjunction always evaluates to true: c != ':' || c != '}'.



Actual results:

Source code is

       if ((c != ':') || (c != '}')) {

Maybe better code

       if ((c != ':') && (c != '}')) {

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

We should fix this at some point. It's a test, so not high-priority.

Comment 2

[Franziskus Kiefer [:franziskus]]

Why is this part built for Firefox? It really shouldn't. How do you build Firefox and how does the log look?

Comment 3

[David Binderman]

>Why is this part built for Firefox? It really shouldn't.

It does seem to be in the deliverable source code. 
I am not sure if it gets built or not.

I don't build Firefox, I just look at the source code of its
components.

It might be the case that this source code file can be
removed from the deliverables.