Closed
Bug 1393083
Opened 7 years ago
Closed 7 years ago
[Form Autofill] CJK names should be combined in the order: familyName + givenName
Categories
(Toolkit :: Form Manager, defect, P3)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: lchang, Assigned: lchang)
References
(Blocks 1 open bug)
Details
(Whiteboard: [form autofill])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
steveck
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
We have a library implemented in bug 1348751 that handled this, but it doesn't work now.
Assignee | ||
Comment 1•7 years ago
|
||
Found the root cause. We use `middle == ""` to verify a CJK name that doesn't contain a middle name. However, it will fail if `middle` is undefined, which happens in the storage because we delete all empty properties after normalizing.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
status-firefox56:
--- → affected
status-firefox57:
--- → affected
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8900312 [details] Bug 1393083 - [Form Autofill] CJK names should be combined in the order: familyName + givenName. https://reviewboard.mozilla.org/r/171684/#review178424
Attachment #8900312 -
Flags: review?(schung) → review+
Pushed by lchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/328376b59095 [Form Autofill] CJK names should be combined in the order: familyName + givenName. r=steveck
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/328376b59095
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8900312 [details] Bug 1393083 - [Form Autofill] CJK names should be combined in the order: familyName + givenName. Approval Request Comment [Feature/Bug causing the regression]: Feature. [User impact if declined]: CJK names are displayed in a wrong order. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: N/A [Is the change risky?]: No. [Why is the change risky/not risky?]: This change only affects Form Autofill system add-on. [String changes made/needed]: N/A
Attachment #8900312 -
Flags: approval-mozilla-beta?
Comment 7•7 years ago
|
||
Comment on attachment 8900312 [details] Bug 1393083 - [Form Autofill] CJK names should be combined in the order: familyName + givenName. Fix wrong order for CJK names. Beta56+.
Attachment #8900312 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/6103dced6357
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•