Closed Bug 1393083 Opened 3 years ago Closed 3 years ago

[Form Autofill] CJK names should be combined in the order: familyName + givenName

Categories

(Toolkit :: Form Manager, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: lchang, Assigned: lchang)

References

(Blocks 1 open bug)

Details

(Whiteboard: [form autofill])

Attachments

(1 file)

We have a library implemented in bug 1348751 that handled this, but it doesn't work now.
Found the root cause.

We use `middle == ""` to verify a CJK name that doesn't contain a middle name. However, it will fail if `middle` is undefined, which happens in the storage because we delete all empty properties after normalizing.
Comment on attachment 8900312 [details]
Bug 1393083 - [Form Autofill] CJK names should be combined in the order: familyName + givenName.

https://reviewboard.mozilla.org/r/171684/#review178424
Attachment #8900312 - Flags: review?(schung) → review+
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/328376b59095
[Form Autofill] CJK names should be combined in the order: familyName + givenName. r=steveck
https://hg.mozilla.org/mozilla-central/rev/328376b59095
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment on attachment 8900312 [details]
Bug 1393083 - [Form Autofill] CJK names should be combined in the order: familyName + givenName.

Approval Request Comment
[Feature/Bug causing the regression]:
Feature.

[User impact if declined]:
CJK names are displayed in a wrong order.

[Is this code covered by automated tests?]:
Yes.

[Has the fix been verified in Nightly?]:
Yes.

[Needs manual test from QE? If yes, steps to reproduce]: 
No.

[List of other uplifts needed for the feature/fix]:
N/A

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
This change only affects Form Autofill system add-on.

[String changes made/needed]:
N/A
Attachment #8900312 - Flags: approval-mozilla-beta?
Comment on attachment 8900312 [details]
Bug 1393083 - [Form Autofill] CJK names should be combined in the order: familyName + givenName.

Fix wrong order for CJK names. Beta56+.
Attachment #8900312 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.