1393132 - Remove old /firefox/new/ and /firefox/firstrun/ templates

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, enhancement)

Description

[Alex Gibson [:agibson]]

When all locales are translated and on the new firefox/new template design, we should remove the old template from the bedrock repo.

We should try and get this done as soon as is feasible, as there will likely be a new download page design for the Firefox 57 release.

Comment 1

[Francesco Lodolo [:flod]]

We have 50 locales, I'm not sure we can aim for more in the short term
https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/new/onboarding.lang

Comment 2

[Alex Gibson [:agibson]]

(In reply to Francesco Lodolo [:flod] from comment #1)
> We have 50 locales, I'm not sure we can aim for more in the short term
> https://l10n.mozilla-community.org/langchecker/
> ?locale=all&website=0&file=firefox/new/onboarding.lang

Does this mean you are ok with us removing the old page?

Also, seeing as /firstrun also shares this same file `firefox/new/onboarding.lang` [1] - should we remove the older /firstrun template too?

[1] https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/firstrun/onboarding.html#L5

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Alex Gibson [:agibson] from comment #2)
> (In reply to Francesco Lodolo [:flod] from comment #1)
> > We have 50 locales, I'm not sure we can aim for more in the short term
> > https://l10n.mozilla-community.org/langchecker/
> > ?locale=all&website=0&file=firefox/new/onboarding.lang
> 
> Does this mean you are ok with us removing the old page?
> 
> Also, seeing as /firstrun also shares this same file
> `firefox/new/onboarding.lang` [1] - should we remove the older /firstrun
> template too?

My answer would be yes to both questions, but I realize it might be a bit early (we exposed the onboarding file on Jul 21).

@Pei
The decision is yours at this point. We could also send out a message, and put a clear deadline: if firefox/new/onboarding.lang is not translated by Aug 29 or similar, we'll start showing en-US content.

Comment 4

[Peiying Mo [:CocoMo]]

Let's move forward with this and I will send out an email regarding the redirect.

This is the completion rate as of now: https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/new/onboarding.lang (50 locales, 97% users of localized version).

Comment 5

[Alex Gibson [:agibson]]

Thanks Flod and Peiying, we'll move forward with this shortly.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/200c2357dc5f83a9340bc1102bba45e5a8039675
[fix bug 1393132] Remove old /firefox/new/ and /firefox/firstrun/ templates

https://github.com/mozilla/bedrock/commit/5ff3d4b663e3a8eef60e8e5d6fa6706d671c2f46
Merge pull request #5081 from alexgibson/bug-1393132-remove-old-firstrun-download-templates

[fix bug 1393132] Remove old /firefox/new/ and /firefox/firstrun/ templates