Remove old /firefox/new/ and /firefox/firstrun/ templates

RESOLVED FIXED

Status

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: agibson, Assigned: agibson)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

a year ago
When all locales are translated and on the new firefox/new template design, we should remove the old template from the bedrock repo.

We should try and get this done as soon as is feasible, as there will likely be a new download page design for the Firefox 57 release.
We have 50 locales, I'm not sure we can aim for more in the short term
https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/new/onboarding.lang
(Assignee)

Comment 2

a year ago
(In reply to Francesco Lodolo [:flod] from comment #1)
> We have 50 locales, I'm not sure we can aim for more in the short term
> https://l10n.mozilla-community.org/langchecker/
> ?locale=all&website=0&file=firefox/new/onboarding.lang

Does this mean you are ok with us removing the old page?

Also, seeing as /firstrun also shares this same file `firefox/new/onboarding.lang` [1] - should we remove the older /firstrun template too?

[1] https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/firstrun/onboarding.html#L5
Flags: needinfo?(francesco.lodolo)
(In reply to Alex Gibson [:agibson] from comment #2)
> (In reply to Francesco Lodolo [:flod] from comment #1)
> > We have 50 locales, I'm not sure we can aim for more in the short term
> > https://l10n.mozilla-community.org/langchecker/
> > ?locale=all&website=0&file=firefox/new/onboarding.lang
> 
> Does this mean you are ok with us removing the old page?
> 
> Also, seeing as /firstrun also shares this same file
> `firefox/new/onboarding.lang` [1] - should we remove the older /firstrun
> template too?

My answer would be yes to both questions, but I realize it might be a bit early (we exposed the onboarding file on Jul 21).

@Pei
The decision is yours at this point. We could also send out a message, and put a clear deadline: if firefox/new/onboarding.lang is not translated by Aug 29 or similar, we'll start showing en-US content.
Flags: needinfo?(francesco.lodolo) → needinfo?(pmo)
Let's move forward with this and I will send out an email regarding the redirect.

This is the completion rate as of now: https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/new/onboarding.lang (50 locales, 97% users of localized version).
Flags: needinfo?(pmo)
(Assignee)

Updated

a year ago
Summary: Remove old /firefox/new/ template → Remove old /firefox/new/ and /firefox/firstrun/ templates
(Assignee)

Comment 5

a year ago
Thanks Flod and Peiying, we'll move forward with this shortly.
(Assignee)

Updated

a year ago
Assignee: nobody → agibson
Status: NEW → ASSIGNED
(Assignee)

Updated

a year ago
Blocks: 1393820

Comment 6

a year ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/200c2357dc5f83a9340bc1102bba45e5a8039675
[fix bug 1393132] Remove old /firefox/new/ and /firefox/firstrun/ templates

https://github.com/mozilla/bedrock/commit/5ff3d4b663e3a8eef60e8e5d6fa6706d671c2f46
Merge pull request #5081 from alexgibson/bug-1393132-remove-old-firstrun-download-templates

[fix bug 1393132] Remove old /firefox/new/ and /firefox/firstrun/ templates

Updated

a year ago
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.