139314 - Freetype alloc's memory even when it is disabled in pref

Status: RESOLVED WORKSFORME

(Core :: Internationalization, defect)

Description

[Suresh Duddi (gone)]

nsFreeTypeInitGlobals(void)+81(37319) Callsite Details:

Composite Byte Size: 20208
Composite Seconds: 57635.914
Composite Weight: 1516646384
Heap Object Count: 768
Heap Operation Seconds: 0.005000

20k is being allocated by freetype.

Comment 1

[Suresh Duddi (gone)]

Attachment: stack trace from spacetrace

Comment 2

[kill this account]

changed title from:

  Freetype being initialized even when it is disabled in pref

to

  Freetype alloc's memory even when it is disabled in pref

Comment 3

[Frank Tang]

bstell- is this something we should ask katakai to look after ?

Comment 4

[kill this account]

Yes, basically we would like the code to not allocate any data if disabled.
To avoid a crash we need to make sure that the code does not try to use any
of these uninitialized items.

Comment 5

[kill this account]

->ftang

Comment 6

[Frank Tang]

bstell:
should we simply wrap
if (enable_freetype2) 
{
}
around

1176   rv = nsFreeTypeInitGlobals();
1177   if (NS_FAILED(rv)) {
1178     FreeGlobals();
1179     return NS_ERROR_OUT_OF_MEMORY;
1180   }

?

reassign to shanjian

Comment 7

[Frank Tang]

shanjian is no longer working on mozilla for 2 years and these bugs are still
here. Mark them won't fix. If you want to reopen it, find a good owner first. 

Comment 8

[Travis Chase]

Mass Bug Re-Open of bugs Frank Tang Closed with no good reason. Spam is his
fault not my own

Comment 9

[Travis Chase]

Mass Re-assinging Frank Tangs old bugs that he closed won't fix and had to be
re-open. Spam is his fault not my own

Comment 10

[Simon Montagu :smontagu]

I think this was fixed in bug 190031, but in any case the source file (gfx/src/xlib/nsFontMetricsXlib.cpp) no longer exists.