Closed
Bug 1393148
Opened 7 years ago
Closed 7 years ago
Hide Topics component if no topics available in Activity Stream
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
Firefox 57
People
(Reporter: k88hudson, Assigned: k88hudson)
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
Mardak
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
This fix hides the topics UI if no topics are available. This change is necessary German users in 56 to not have a broken experience.
Assignee | ||
Updated•7 years ago
|
Summary: Hide Topics component if no topics available → Hide Topics component if no topics available in Activity Stream
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8900388 -
Flags: review?(edilee)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8900388 [details] Bug 1393148 - Hide Topics component if no topics available in Activity Stream https://reviewboard.mozilla.org/r/171740/#review176982 Looks fine for nightly/mozilla-central. Won't apply cleanly to beta given the context difference: ` const maxCards = 3 * maxRows;` only exists on m-c. Also I guess this will look untested because we don't export content-src tests.
Attachment #8900388 -
Flags: review?(edilee) → review+
Pushed by khudson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/360a9abdd9ea Hide Topics component if no topics available in Activity Stream r=Mardak
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/360a9abdd9ea
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8900388 [details] Bug 1393148 - Hide Topics component if no topics available in Activity Stream Approval Request Comment [Feature/Bug causing the regression]: Topics are broken for users in Germany [User impact if declined]: The pocket experience will appear buggy/broken for German users for the Activity Stream shield study [Is this code covered by automated tests?]: Yes, in https://github.com/mozilla/activity-stream [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: No [Is the change risky?]: No [Why is the change risky/not risky?]: One line change, affects shield study only (Activity Stream is pref'd off by default) [String changes made/needed]: None
Attachment #8900388 -
Flags: approval-mozilla-beta?
Updated•7 years ago
|
status-firefox56:
--- → affected
Comment 6•7 years ago
|
||
Comment on attachment 8900388 [details] Bug 1393148 - Hide Topics component if no topics available in Activity Stream UI polishment for Activity Stream. Beta56+.
Attachment #8900388 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•7 years ago
|
Assignee: nobody → khudson
Comment 7•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/5ade015bbd6d
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•