1393152 - Explore by touch in Fennec is broken

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P3)

Description

[Eitan Isaacson [:eeejay]]

STR:

1. Enable Talkback
2. Start Nightly
3. Load wikipedia.org
4. Press and hold the English tile.

Result:
 Deutsch is highlighted.

Expected:
 English should be highlighted.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Do we know what version of Firefox/Fennec are affected?

Comment 2

[Eitan Isaacson [:eeejay]]

Release, Beta, and Nightly.

Comment 3

[Mike Taylor [:miketaylr]]

Eitan, would you be able to find a regression range using mozregression?

Comment 4

[Eitan Isaacson [:eeejay]]

15:17.91 INFO: Got as far as we can go bisecting nightlies...
15:17.91 INFO: Last good revision: 7db14bebae9196d780b1d64d2fd32d1bda26828b (2015-08-30)
15:17.91 INFO: First bad revision: f2518b8a7b97b5bb477e94bc9131584007aac887 (2015-08-31)
15:17.91 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7db14bebae9196d780b1d64d2fd32d1bda26828b&tochange=f2518b8a7b97b5bb477e94bc9131584007aac887

It couldn't go further with taskcluster builds. Assuming because they don't exist anymore.

Anyway, my hunch is that bug 1394526 is a regression of bug 1197811.

Comment 5

[Mike Taylor [:miketaylr]]

Thanks Eitan. kats, does Comment #4 seem like the right regressing bug?

Comment 6

[Kartikaya Gupta (email:[e-mail])]

(In reply to Eitan Isaacson [:eeejay] from comment #4)
> Anyway, my hunch is that bug 1394526 is a regression of bug 1197811.

It's not clear to me why bug 1394526 is relevant here. Were you bisecting this bug or bug 1394526? Or are they just different manifestations of the same bug? If that's the case, did the fix for bug 1394526 fix this bug?

(In reply to Mike Taylor [:miketaylr] from comment #5)
> Thanks Eitan. kats, does Comment #4 seem like the right regressing bug?

From the pushlog in comment 4, bug 1197811 does seem to be the most relevant bug for having regressed event y-coordinate offsets on Fennec, yes. That being said, the code in question has been pretty much entirely rewritten since then, Randall now owns the new dynamic toolbar implementation so if there are still bugs related to y-coordinate mispositioning due to that, he can look into them.

Comment 7

[Eitan Isaacson [:eeejay]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #6)
> (In reply to Eitan Isaacson [:eeejay] from comment #4)
> > Anyway, my hunch is that bug 1394526 is a regression of bug 1197811.
> 
> It's not clear to me why bug 1394526 is relevant here. Were you bisecting
> this bug or bug 1394526? Or are they just different manifestations of the
> same bug? If that's the case, did the fix for bug 1394526 fix this bug?

Sorry I wasn't clear about this. Yeah, I think they are different manifestations of the same bug. Instead of bisecting this bug, I bisected bug 1394526 because the STR were quicker.

TalkBack sends HOVER motion events to apps, so it's basically the same code path as mouse HOVER events. 

Using wikipedia's language landing page. I put the mouse cursor over one of the links. If the link below it got underlined, it was "bad", otherwise it was "good". That's how I got to bug 1197811.

> 
> (In reply to Mike Taylor [:miketaylr] from comment #5)
> > Thanks Eitan. kats, does Comment #4 seem like the right regressing bug?
> 
> From the pushlog in comment 4, bug 1197811 does seem to be the most relevant
> bug for having regressed event y-coordinate offsets on Fennec, yes. That
> being said, the code in question has been pretty much entirely rewritten
> since then, Randall now owns the new dynamic toolbar implementation so if
> there are still bugs related to y-coordinate mispositioning due to that, he
> can look into them.

Randall thinks the regression happened later (from bug 1394526, comment #18):
> I fixed it originally in Bug 1248254 for the v2 dynamic toolbar. Then broke
> it again when I did the v3 toolbar which shipped in 55.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Thanks. So is this fixed with the patch from bug 1394526?

Comment 9

[Eitan Isaacson [:eeejay]]

Yes.