1393193 - Warning but no Next Steps on revisions when the user has given no reviewers

Status: NEW

(Conduit :: Phabricator, enhancement, P3)

Description

[Māris Fogels [:mars] (please needinfo)]

I sometimes create code reviews in Phabricator without first knowing who will be reviewing my code.  When I do this I leave the list of reviewers on my revision empty, and I see a big yellow warning on the Revision page that says "This revision needs review, but there are no reviewers specified."  However, I don't see a button that would take me straight to the "Add a reviewer" page to get rid of the warning.

To add a reviewer, I have to find and click "Edit Revision" in the right-hand menu, then find and click "Reviewers" on the edit page.

If adding a reviewer is an action important enough to put a Big Yellow Warning banner on the page, and if adding a reviewer is almost always the next step that I am going to take in the code review lifecycle, then it would be helpful to have a button that lets me take the "Add a reviewer" action right away without any extra clicks so I can clear the warning.

Two possible locations I would expect to see the button to add/edit reviewers would be in the warning banner itself or possibly in the right-hand actions menu of the Revision.

Comment 1

[Phabricator Automation]

Attachment: Install arc in its own container for development

Comment 2

[Phabricator Automation]

Comment on attachment 8940765 [details]
Install arc in its own container for development

David Walsh :davidwalsh has approved the revision.
Piotr Zalewa [:zalun] has approved the revision.

https://phabricator.services.mozilla.com/D2

Comment 3

[Mark Côté [:mcote]]

I believe the revision here was associated with the wrong bug... throwing this into the backlog.