add buildbot configs for running remaining windows 8 tests on windows 10

RESOLVED FIXED

Status

RESOLVED FIXED
a year ago
3 months ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [PI:September])

Attachments

(3 attachments, 5 obsolete attachments)

(Assignee)

Description

a year ago
currently we still run windows 8 tests of:
mochitest-browser-chrome
mochitest-media
mochitest-gpu
mochitest-webgl
reftest
reftest-no-accel
mochitest-chrome
mochitest-clipboard

lets add buildbot configs to support running these on all 57+ branches- then taskcluster can schedule via BBB what is green and ready.
(Assignee)

Comment 1

a year ago
Created attachment 8900437 [details] [diff] [review]
adding win10 buildbot jobs

:kmoir, I am relying on you again for use of your local buildbot setup to help me get a builder diff.  Maybe if you just see something wrong with my patch that would be beneficial to call out as well.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8900437 - Flags: feedback?(kmoir)
So looking at the patches, I noticed that the tests are enabled on cedar, graphics, jamun and ash.  However, in mozilla-test/project_branches.py these don't have the win10_64 or win8_64 platform enabled.  The builder diff doesn't show any changes.

Updated

a year ago
Attachment #8900437 - Flags: feedback?(kmoir) → feedback-
(Assignee)

Comment 3

a year ago
Created attachment 8900899 [details] [diff] [review]
adding win10 buildbot jobs

another attempt, this time for 57+ copy all win8 -> win10.
Attachment #8900437 - Attachment is obsolete: true
Attachment #8900899 - Flags: feedback?(kmoir)
Comment on attachment 8900899 [details] [diff] [review]
adding win10 buildbot jobs

This doesn't work, I think you need to check if test_type exists for the branches as you try to assign it

However, I haven't been able to test a patch because I'm on release duty and have been busy pushing out the foxes so will look again next week
Attachment #8900899 - Flags: feedback?(kmoir)
(Assignee)

Comment 5

a year ago
Created attachment 8902576 [details] [diff] [review]
adding win10 buildbot jobs

:kmoir, I am at a loss for how to realistically do this work- can you fix the patch or help find someone who can?  I have updated the patch to attempt to add the win10 list of tests properly.
Attachment #8900899 - Attachment is obsolete: true
Attachment #8902576 - Flags: feedback?(kmoir)
Yes, I will look at it within the next 24hrs. Releaseduty has been very busy, I apologize for not getting to this bug.
debugging this now
Created attachment 8903328 [details] [diff] [review]
bug1393198.patch

updated patch
Attachment #8902576 - Attachment is obsolete: true
Attachment #8902576 - Flags: feedback?(kmoir)
Created attachment 8903329 [details]
bug1393198builder.diff

not sure if this is the builder diff you're looking for

Updated

a year ago
Attachment #8903329 - Attachment is patch: false
(Assignee)

Comment 10

a year ago
thanks :kmoir!  I think this is really close except for some reason we have esr52, mozilla-release, and mozilla-beta receiving new tests.  My concern there is that we would enable tests by default, when in fact some changes will need to be in tree in order for the tests to run and be green.

Looking over the updated patch for this I cannot see how we would be adding code for the downstream branches.  

I am tempted to have something like:
   if branch in ['mozilla-beta', 'mozilla-release', 'mozilla-esr52']:
        continue

but that is only going to give us headaches when we merge.

Another option is to go forward with this and just hide the win10 jobs on esr/release/beta- I would worry about the beta jobs as we have a fair amount of traffic there.

:kmoir: Do you have ideas on how to restrict this so it can ride the trains?
Flags: needinfo?(kmoir)
Created attachment 8903623 [details] [diff] [review]
bug1393198-3.patch
Attachment #8903328 - Attachment is obsolete: true
Flags: needinfo?(kmoir)
Created attachment 8903624 [details] [diff] [review]
bug1393198builder-3.diff
Attachment #8903329 - Attachment is obsolete: true
(Assignee)

Comment 13

a year ago
Comment on attachment 8903623 [details] [diff] [review]
bug1393198-3.patch

Review of attachment 8903623 [details] [diff] [review]:
-----------------------------------------------------------------

builder diff looks good except it has mozilla-beta tests- maybe that isn't a concern

::: mozilla-tests/config.py
@@ +3140,5 @@
> +                    branch['platforms'][platform][wp][test_type].append(test)
> +
> +#Bug 1393198 - add buildbot configs for running remaining windows 8 tests on windows 10 - remove them on non trunk branches
> +# and leave on beta
> +for name, branch in items_before(BRANCHES, 'gecko_version', 56):

will we schedule on beta by default with the buildbot scheduler?  If not, this is ok, if so, make this items_before(57)
I did have this but changed it because this didn't have the Devedition win10 tests enabled since they are only enabled on beta.  I wasn't sure if this had to wait until uplift since we are just copying tests.  I can change it if needed.
(Assignee)

Comment 15

a year ago
it might be worthwhile to have this on beta, as long as we only schedule via BBB :)
(Assignee)

Comment 16

a year ago
Comment on attachment 8903623 [details] [diff] [review]
bug1393198-3.patch

Review of attachment 8903623 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for updating this patch.  From what I can tell, we use taskcluster+BBB to schedule all windows jobs on 56+, so this should do what we need it to do :)
Attachment #8903623 - Flags: review+
(Assignee)

Comment 17

a year ago
I am happy to land this- although I think waiting for Tuesday to land and reconfig is probably better
(Assignee)

Updated

a year ago
Whiteboard: [PI:August] → [PI:September]
(Assignee)

Comment 18

a year ago
just landed this:
https://hg.mozilla.org/build/buildbot-configs/rev/adab2d67f17dc19cf3e74b629cc38d506722726b

will wait for travis, then I believe an auto reconfig- need to watch out for the magical 10K jobs in the databases.
(Assignee)

Comment 20

a year ago
Created attachment 8904665 [details] [diff] [review]
add config file definitions to win10
Attachment #8904665 - Flags: review?(kmoir)

Updated

a year ago
Attachment #8904665 - Flags: review?(kmoir) → review+
(Assignee)

Comment 21

a year ago
thanks for the quick review, landed and waiting for unittest results:
https://hg.mozilla.org/build/buildbot-configs/rev/60eaa164453f44a5147236b318dc1f8b1f1888b5
(Assignee)

Updated

a year ago
Blocks: 1397226
(Assignee)

Comment 22

a year ago
this is working for me on try server
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.