1393237 - Bookmark star has wrong tooltip after bookmarking a page

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Drew Willcoxon :adw]

When you click the bookmark star in the urlbar to bookmark a page, its tooltip still reads "Bookmark this page" instead of "Edit this bookmark."  It looks like the problem is related to the star animation on click.  #star-button-animatable-image doesn't have a tooltip, and it's being shown on top of #star-button.  When you bookmark a page in a way that bypasses the star button (like the menu item), the problem doesn't happen.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1393237 - Bookmark star has wrong tooltip after bookmarking a page.

Review commit: https://reviewboard.mozilla.org/r/171854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171854/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8900486 [details]
Bug 1393237 - Bookmark star has wrong tooltip after bookmarking a page.

https://reviewboard.mozilla.org/r/171854/#review177108

I imagine we could clean up some CSS that uses `#star-button[starred] + #star-button-animatable-box > #star-button-animatable-image` to now just be `#star-button-animatable-image[starred]`. Do you want to do that while you're here?

Comment 3

[Drew Willcoxon :adw]

Sounds good, thanks for the quick review.

Comment 4

[Drew Willcoxon :adw]

Summarizing a conversation between Jared and me on IRC:

All the relevant selectors look like this:

> #star-button-box[animationsenabled] > #star-button[starred][animate] + #star-button-animatable-box > #star-button-animatable-image

`animate` isn't set on the animatable-image, so it's not really possible to simplify these selectors more.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7e15a0d5195
Bookmark star has wrong tooltip after bookmarking a page. r=jaws

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e7e15a0d5195

Comment 7

[Mohammad Maruf Rahman]

I have reproduced this bug with 57.0a1 (2017-08-23) (64-bit) on Windows 7, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20171016185129
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 8

[Mohammed Adam]

I have Reproduced this bug with Nightly 59.0a1 (2017-12-10) on Windows 10, (64-bit)

Status: Fixed & Verified 

Useragent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 
BuildID: 20171210220040

[testday-20171208]