Bookmark star has wrong tooltip after bookmarking a page

RESOLVED FIXED in Firefox 57

Status

()

Firefox
General
P1
normal
RESOLVED FIXED
11 months ago
7 months ago

People

(Reporter: adw, Assigned: adw)

Tracking

unspecified
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 fixed, firefox59 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
When you click the bookmark star in the urlbar to bookmark a page, its tooltip still reads "Bookmark this page" instead of "Edit this bookmark."  It looks like the problem is related to the star animation on click.  #star-button-animatable-image doesn't have a tooltip, and it's being shown on top of #star-button.  When you bookmark a page in a way that bypasses the star button (like the menu item), the problem doesn't happen.
Comment hidden (mozreview-request)

Comment 2

11 months ago
mozreview-review
Comment on attachment 8900486 [details]
Bug 1393237 - Bookmark star has wrong tooltip after bookmarking a page.

https://reviewboard.mozilla.org/r/171854/#review177108

I imagine we could clean up some CSS that uses `#star-button[starred] + #star-button-animatable-box > #star-button-animatable-image` to now just be `#star-button-animatable-image[starred]`. Do you want to do that while you're here?
Attachment #8900486 - Flags: review?(jaws) → review+
(Assignee)

Comment 3

11 months ago
Sounds good, thanks for the quick review.
(Assignee)

Comment 4

11 months ago
Summarizing a conversation between Jared and me on IRC:

All the relevant selectors look like this:

> #star-button-box[animationsenabled] > #star-button[starred][animate] + #star-button-animatable-box > #star-button-animatable-image

`animate` isn't set on the animatable-image, so it's not really possible to simplify these selectors more.

Comment 5

11 months ago
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7e15a0d5195
Bookmark star has wrong tooltip after bookmarking a page. r=jaws
https://hg.mozilla.org/mozilla-central/rev/e7e15a0d5195
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
QA Whiteboard: [good first verify]

Comment 7

9 months ago
I have reproduced this bug with 57.0a1 (2017-08-23) (64-bit) on Windows 7, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20171016185129
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [good first verify] → [good first verify] [bugday-20171018]

Comment 8

7 months ago
I have Reproduced this bug with Nightly 59.0a1 (2017-12-10) on Windows 10, (64-bit)

Status: Fixed & Verified 

Useragent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 
BuildID: 20171210220040

[testday-20171208]

Updated

7 months ago
status-firefox59: --- → verified
You need to log in before you can comment on or make changes to this bug.