13933 - Initial editor page is marked "modified" without user input

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[sujay]

using 9/15 build of apprunner

1) launch apprunner
2) launch editor
3) type nothing
4) File | Close/Exit

the save prompt comes up. it shouldn't because you haven't typed anything..

compare to 4.x behavior..

all platforms.

Comment 1

[Charles Manske]

My code calls
diskDoc->GetModCount(&modCount)
which is returning 1 even without typing anything.
So this is in Simon's code. Unless he intentionally is setting it to 1
just for the test document?

Comment 2

[Simon Fraser [no longer active]]

no, I'm not setting it to one. Something is modifying the doc. Perhaps your
stylesheet application, charlie?

Comment 3

[buster]

sounds like simple cleanup, can happen late in the cycle.

Comment 4

[Simon Fraser [no longer active]]

What's happening here is that the doc is being marked as modified by the
transaction that creates the bogus node. We need to call ResetDocModCount() at
an opportune time.

Comment 5

[Simon Fraser [no longer active]]

Here's a patch.

Index: nsEditor.cpp
===================================================================
RCS file: /cvsroot/mozilla/editor/base/nsEditor.cpp,v
retrieving revision 1.226
diff -r1.226 nsEditor.cpp
297a298,301
>   // nuke the modification count, so the doc appears unmodified
>   // do this before we notify listeners
>   ResetDocModCount();
>

Comment 6

[Kathleen :Brade]

reassign to myself; I'll check this in for Simon as we had discussed.

Comment 7

[Kathleen :Brade]

I checked in Simon's patch; should be able to test today (M13).

Comment 8

[Kathleen :Brade]

resolve fixed.

Comment 9

[sujay]

verified in 12/21 build.