Add a Toast or Modal to confirm actions that don't have a user perceivable change.

VERIFIED FIXED

Status

()

Firefox for iOS
Menu and Toolbar
P3
normal
VERIFIED FIXED
5 months ago
3 months ago

People

(Reporter: farhan, Unassigned)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios10.0, fxios-v10.0 verified, fxios-v11.0 verified)

Details

(Whiteboard: [Photon])

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review | Splinter Review
(Reporter)

Description

5 months ago
For actions such as bookmark and "Add to reading list" show a toast or modal to signal to the user that an action was completed. 

The following menu options need some sort of confirmation
- Copy URL
- Add Bookmark
- Add to reading List
(Reporter)

Comment 1

5 months ago
How this looks will depend on the UI. But for a starter, reusing SimpleToast is a good first step.
(Reporter)

Updated

4 months ago
Priority: -- → P3

Comment 2

4 months ago
Created attachment 8915727 [details] [review]
Pull request
Attachment #8915727 - Flags: review?(fpatel)
(Reporter)

Comment 3

3 months ago
https://github.com/mozilla-mobile/firefox-ios/commit/06f686c01eb05641aa2737127e0271866926120e
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
(Reporter)

Updated

3 months ago
Attachment #8915727 - Flags: review?(fpatel) → review+

Updated

3 months ago
Whiteboard: [Photon] → [Photon][needsuplift]

Comment 4

3 months ago
Verifying as fix on master fac4e03e6103 and beta 10.0(7025). The toast is displayed when Copying a URL, Adding a Bookmark, Adding a page to Reading List from the page action menu.
Status: RESOLVED → VERIFIED
status-fxios-v10.0: --- → verified
status-fxios-v11.0: --- → verified
(Reporter)

Updated

3 months ago
Whiteboard: [Photon][needsuplift] → [Photon]
You need to log in before you can comment on or make changes to this bug.