1393323 - stylo: transition is not triggered when a property in a css rule is directly changed and the target element has running animations

Status: NEW

(Core :: CSS Parsing and Computation, defect, P4)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: An example

See attaching file.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: transition.html

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I came up with an idea to fix this. But I am not sure the idea has no side effect.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a353611b8be9c762403fc9b501260f826ad076b5

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Oops, the idea is not good. In normal traversal, we do drop all animation restyle hints unlike animation-only restyle.

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

For my own reference, this test passes most of the time for me. When I run the test locally, it fails about 1 in 20 times. When I load it over HTTP it fails about 1 in 30~40 times or so.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

CCing Xidorn, he might have a good idea to solve this.

I should note about what happens in the test case:

When a value in a css rule is changed by CSSOM, the value is replaced in the rule block before traversal.  So, if an element, which is applied to the css rule, has an animation, the new value is used in animation-only restyle, then, we can't trigger transitions properly in normal traversal because no value changed in the normal traversal.  What I tried in comment 2 is to skip the first animation-only restyle when any css rules changed, but this way makes our traversal code complex since normal traversal is supposed to be done after animation-only restyle (i.e. there is no pending animation restyles in normal traversal).

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

I have no idea, unfortunately. I'm not familiar with the traversals.

I think for setting property value, Gecko and Stylo should share majority of the idea. Both of them change the value in rule block directly.

Comment 7

[Bobby Holley (:bholley)]

Hiro, what should the priority of this be?

Comment 8

[Hiroyuki Ikezoe (:hiro)]

I think we can set this to P3 since I believe triggering transitions with modifying values by CSSOM during other animations are running is rarely used.
Brian, please feel free to bump this priority if you think this is an important bug to fix in 57 release.

Comment 9

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Yes, I also think this is P3.

Comment 10

[Brian Birtles (:birtles, Feb 26~ parental leave)]

We should fix this, but it's too risky to do it in 57 so I'm going to mark this as P4 for now.

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Yeah, agree. I have only one risky way to solve this.

Comment 12

[Chris Peterson [:cpeterson]]

status-firefox57=wontfix unless someone thinks this bug should block 57

Comment 13

[Emilio Cobos Álvarez (:emilio)]

We cannot even use the same hack (the dirty style attribute stuff) for CSS rules since they're not unique...