Closed
Bug 1393336
Opened 7 years ago
Closed 7 years ago
Remove WaitForCDM state from MDSM.
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: kikuo, Assigned: kikuo)
References
Details
Attachments
(1 file)
Per discussion with JW, it's simpler for MDSM to be aware of waiting for data instead of entering WaitForCDM state if the CDMProxy is set to null. (MediaKey is detached from HTMLMediaElement).
Updated•7 years ago
|
Priority: -- → P3
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8901103 [details] Bug 1393336 - Remove WaitForCDM state from MDSM. https://reviewboard.mozilla.org/r/172594/#review177844 I'd like to make it possible to detach / reattach MediaKey for HTMLMediaElement, it's necessary to make MediaDecoder able to set null as cdm proxy to MFR. Removing WaitForCDM state in MSMD could simply the logic.
Assignee | ||
Updated•7 years ago
|
Attachment #8901103 -
Flags: review?(jwwang)
Updated•7 years ago
|
Component: Audio/Video → Audio/Video: Playback
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8901103 [details] Bug 1393336 - Remove WaitForCDM state from MDSM. https://reviewboard.mozilla.org/r/172594/#review178460 LGTM. r?jya for MFR changes.
Attachment #8901103 -
Flags: review?(jwwang) → review+
Updated•7 years ago
|
Attachment #8901103 -
Flags: review?(jyavenard)
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8901103 [details] Bug 1393336 - Remove WaitForCDM state from MDSM. https://reviewboard.mozilla.org/r/172594/#review178576 ::: dom/media/MediaDecoder.cpp:1462 (Diff revision 2) > - mCDMProxyPromiseHolder.ResolveIfExists(aProxy, __func__); > + nsCOMPtr<nsIRunnable> r = NS_NewRunnableFunction( > + "MediaFormatReader::SetCDMProxy", > + [reader, proxy]() { > + reader->SetCDMProxy(proxy); > + }); > + mReader->OwnerThread()->Dispatch(r.forget()); I think dispatching to the reader's thread should be up to the reader. MediaDecoder shouldn't have to know about the MediaDecoderReader threading model.
Attachment #8901103 -
Flags: review?(jyavenard) → review+
Comment 6•7 years ago
|
||
We had a similar discussion here about the thread model of MDR: https://bugzilla.mozilla.org/show_bug.cgi?id=1215003&mark=18-22#c18
Assignee | ||
Comment 7•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8901103 [details] Bug 1393336 - Remove WaitForCDM state from MDSM. https://reviewboard.mozilla.org/r/172594/#review178576 > I think dispatching to the reader's thread should be up to the reader. > > MediaDecoder shouldn't have to know about the MediaDecoderReader threading model. I suggest that we could have a discussion in Bug 1394728 to find out which way we want MFR to go or how should MediaDecoder / MDSM / MFR inter-op with each. I would drop this issue for now as I just wanna follow the way how MFR is used in MediaDecoder to avoid a inconsistent style.
Assignee | ||
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8901103 [details] Bug 1393336 - Remove WaitForCDM state from MDSM. https://reviewboard.mozilla.org/r/172594/#review178990 https://treeherder.mozilla.org/#/jobs?repo=try&revision=b31c285e131d Some orange, but they're not related.
Pushed by kikuo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59834f182e67 Remove WaitForCDM state from MDSM. r=jwwang,jya
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/59834f182e67
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•