1393355 - Move SetTextRangeStyle from nsISelectionPrivate to Selection

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Description

[Makoto Kato [:m_kato]]

There is no reason that SetTextRangeStyle is defined at nsISelectionPrivate and SetTextRangeStyle isn't scriptable, and is called from CompositionTransaction::SetIMESelection only.  So we should move this to Selection.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1393355 - Move SetTextRangeStyle from nsISelectionPrivate to Selection.

There is no reason that SetTextRangeStyle is defined at nsISelectionPrivate.  Also, SetTextRangeStyle isn't scriptable, and is called from CompositionTransaction::SetIMESelection only.  So we should move this to Selection.

Review commit: https://reviewboard.mozilla.org/r/172038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172038/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8900618 [details]
Bug 1393355 - Move SetTextRangeStyle from nsISelectionPrivate to Selection.

https://reviewboard.mozilla.org/r/172038/#review177324

::: dom/base/Selection.h:297
(Diff revision 1)
> +   * Set the painting style for the range. The range must be a range in
> +   * the selection. The textRangeStyle will be used by text frame
> +   * when it is painting the selection.
> +   */
> +  nsresult SetTextRangeStyle(nsRange* aRange,
> +                             const mozilla::TextRangeStyle& aTextRangeStyle);

I guess |mozilla::| isn't necessary here.

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8900618 [details]
Bug 1393355 - Move SetTextRangeStyle from nsISelectionPrivate to Selection.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172038/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4deeff0c8f25
Move SetTextRangeStyle from nsISelectionPrivate to Selection. r=masayuki

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4deeff0c8f25