1393361 - Icons for themes are not listed in "Themes" tab in Add-ons Manager/about:addons, if installed from "Get Add-ons" tab

Status: RESOLVED INCOMPLETE

(Toolkit :: Add-ons Manager, defect)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

[Affected versions]:
Firefox 57.0a1 (2017-08-23) 

[Affected platforms]:
Windows 7 64-bit
Mac OS X 10.12.3

[Steps to reproduce]:
1. Go to about:addons -> Get Add-ons tab and install a theme (i.e Ibbis Persona)
2. Go to "Appearance" tab and observe installed theme

[Expected Results]:
Installed theme has an icon.

[Actual Results]:
Installed theme has no icon.

[Additional Notes]:
Issue is reproducing from AMO also, if using new desktop pages format. (Load https://addons.mozilla.org/en-US/firefox/ -> Click on "View Mobile Site" from page footer -> Install a theme)
Attaching screenshot for this issue.

Comment 1

[Valentina Virlics [:vvalentina], Ecosystem QA]

Attachment: no_theme_icon.png

Comment 3

[Valentina Virlics [:vvalentina], Ecosystem QA]

Attachment: theme-icons.zip

The fix for this is adding a general icon for all themes installed from Disco Pane or new AMO desktop pages? Seems a bit weird.
Installing the same theme from AMO (classic pages) will display corresponding icon.
Please see attached screenshots.
Thanks in advance!

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Yep, thanks for checking!

@  Dale Harvey (:daleharvey) - Could you look on this? As it seems like Firefox doesn't show theme preview as icon anymore, just default standard theme icon is used. Let's hope, it's not intended. :)

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: from_amo.png

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: same_icon.png

Comment 7

[Andrew Swan [:aswan]]

Upon looking closer, it looks like the Disco Pane isn't providing the same information for a LWT install that regular AMO install buttons are.  Filed https://github.com/mozilla/addons-server/issues/6261, to be continued over there.