1393369 - Remove MediaResource::GetCurrentPrincipal()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

We will virtualize MediaDecoder::GetCurrentPrincipal() so the sub-classes know how to calculate the current principal.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1393369. P1 - virtualize MediaDecoder::GetCurrentPrincipal() so the sub-classes know how to calculate the current principal.

Review commit: https://reviewboard.mozilla.org/r/173044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173044/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1393369. P2 - remove MediaResource::GetCurrentPrincipal().

Review commit: https://reviewboard.mozilla.org/r/173046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173046/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1393369. P3 - remove unused code.

Review commit: https://reviewboard.mozilla.org/r/173048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173048/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1393369. P4 - remove MediaSourceResource::GetCurrentPrincipal().

Review commit: https://reviewboard.mozilla.org/r/173050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173050/

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8901635 [details]
Bug 1393369. P1 - virtualize MediaDecoder::GetCurrentPrincipal() so the sub-classes know how to calculate the current principal.

https://reviewboard.mozilla.org/r/173044/#review178368

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8901636 [details]
Bug 1393369. P2 - remove MediaResource::GetCurrentPrincipal().

https://reviewboard.mozilla.org/r/173046/#review178370

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8901637 [details]
Bug 1393369. P3 - remove unused code.

https://reviewboard.mozilla.org/r/173048/#review178372

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8901638 [details]
Bug 1393369. P4 - remove MediaSourceResource::GetCurrentPrincipal().

https://reviewboard.mozilla.org/r/173050/#review178374

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/772c18f3310d
P1 - virtualize MediaDecoder::GetCurrentPrincipal() so the sub-classes know how to calculate the current principal. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9bf0a81420d1
P2 - remove MediaResource::GetCurrentPrincipal(). r=gerald
https://hg.mozilla.org/integration/autoland/rev/6657a55cf952
P3 - remove unused code. r=gerald
https://hg.mozilla.org/integration/autoland/rev/f06ff175be4f
P4 - remove MediaSourceResource::GetCurrentPrincipal(). r=gerald

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/772c18f3310d
https://hg.mozilla.org/mozilla-central/rev/9bf0a81420d1
https://hg.mozilla.org/mozilla-central/rev/6657a55cf952
https://hg.mozilla.org/mozilla-central/rev/f06ff175be4f