Closed Bug 1393369 Opened 2 years ago Closed 2 years ago

Remove MediaResource::GetCurrentPrincipal()

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(4 files)

We will virtualize MediaDecoder::GetCurrentPrincipal() so the sub-classes know how to calculate the current principal.
Assignee: nobody → jwwang
Blocks: 1373160
Priority: -- → P3
Attachment #8901635 - Flags: review?(gsquelart)
Attachment #8901636 - Flags: review?(gsquelart)
Attachment #8901637 - Flags: review?(gsquelart)
Attachment #8901638 - Flags: review?(gsquelart)
Comment on attachment 8901635 [details]
Bug 1393369. P1 - virtualize MediaDecoder::GetCurrentPrincipal() so the sub-classes know how to calculate the current principal.

https://reviewboard.mozilla.org/r/173044/#review178368
Attachment #8901635 - Flags: review?(gsquelart) → review+
Comment on attachment 8901636 [details]
Bug 1393369. P2 - remove MediaResource::GetCurrentPrincipal().

https://reviewboard.mozilla.org/r/173046/#review178370
Attachment #8901636 - Flags: review?(gsquelart) → review+
Comment on attachment 8901637 [details]
Bug 1393369. P3 - remove unused code.

https://reviewboard.mozilla.org/r/173048/#review178372
Attachment #8901637 - Flags: review?(gsquelart) → review+
Comment on attachment 8901638 [details]
Bug 1393369. P4 - remove MediaSourceResource::GetCurrentPrincipal().

https://reviewboard.mozilla.org/r/173050/#review178374
Attachment #8901638 - Flags: review?(gsquelart) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/772c18f3310d
P1 - virtualize MediaDecoder::GetCurrentPrincipal() so the sub-classes know how to calculate the current principal. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9bf0a81420d1
P2 - remove MediaResource::GetCurrentPrincipal(). r=gerald
https://hg.mozilla.org/integration/autoland/rev/6657a55cf952
P3 - remove unused code. r=gerald
https://hg.mozilla.org/integration/autoland/rev/f06ff175be4f
P4 - remove MediaSourceResource::GetCurrentPrincipal(). r=gerald
You need to log in before you can comment on or make changes to this bug.