1393379 - Make MediaDecoder::AddSizeOfResources pure virtual

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

Sub-classes have more details about how to calculate the resource size. It also allows up to remove SizeOfExcludingThis() and SizeOfIncludingThis() from MediaResource.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

This is also a step forward to remove MediaDecoder::GetResource() and make porting to Servo easier.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1393379. P1 - make MediaDecoder::AddSizeOfResources pure virtual.

We will move the implementation to sub-classes which have more details
about how to calculate the resource size.

Review commit: https://reviewboard.mozilla.org/r/173098/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173098/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1393379. P2 - remove MediaResource::SizeOfIncludingThis/SizeOfExcludingThis.

Review commit: https://reviewboard.mozilla.org/r/173100/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173100/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8901672 [details]
Bug 1393379. P1 - make MediaDecoder::AddSizeOfResources pure virtual.

https://reviewboard.mozilla.org/r/173098/#review178446

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8901673 [details]
Bug 1393379. P2 - remove MediaResource::SizeOfIncludingThis/SizeOfExcludingThis.

https://reviewboard.mozilla.org/r/173100/#review178448

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6683845d49b5
P1 - make MediaDecoder::AddSizeOfResources pure virtual. r=gerald
https://hg.mozilla.org/integration/autoland/rev/fdade67e7e78
P2 - remove MediaResource::SizeOfIncludingThis/SizeOfExcludingThis. r=gerald

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6683845d49b5
https://hg.mozilla.org/mozilla-central/rev/fdade67e7e78