Remove MediaDecoder::GetResource()

RESOLVED FIXED in Firefox 57

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

9 months ago
Blessed is MediaDecoder which is ignorant of MediaResource. This makes porting MediaDecoder to Servo easier.
(Assignee)

Updated

9 months ago
Assignee: nobody → jwwang
Blocks: 1388605
Priority: -- → P3
(Assignee)

Comment 1

9 months ago
This also allows up to remove MediaResource from the base class of HLSResource and MediaSourceResource.
Blocks: 1373160
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Attachment #8902081 - Flags: review?(gsquelart)
Attachment #8902082 - Flags: review?(gsquelart)

Comment 4

9 months ago
mozreview-review
Comment on attachment 8902081 [details]
Bug 1393386. P1 - make PinForSeek/UnpinForSeek pure virtual.

https://reviewboard.mozilla.org/r/173498/#review178846
Attachment #8902081 - Flags: review?(gsquelart) → review+

Comment 5

9 months ago
mozreview-review
Comment on attachment 8902082 [details]
Bug 1393386. P2 - remove MediaDecoder::GetResource().

https://reviewboard.mozilla.org/r/173500/#review178848

You make it look too easy!
Attachment #8902082 - Flags: review?(gsquelart) → review+
(Assignee)

Comment 6

9 months ago
Thanks!

Comment 7

9 months ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96a77311197a
P1 - make PinForSeek/UnpinForSeek pure virtual. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9b9102b84ebc
P2 - remove MediaDecoder::GetResource(). r=gerald
https://hg.mozilla.org/mozilla-central/rev/96a77311197a
https://hg.mozilla.org/mozilla-central/rev/9b9102b84ebc
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.