Closed Bug 1393386 Opened 3 years ago Closed 3 years ago

Remove MediaDecoder::GetResource()

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

Blessed is MediaDecoder which is ignorant of MediaResource. This makes porting MediaDecoder to Servo easier.
Assignee: nobody → jwwang
Blocks: servo-media
Priority: -- → P3
This also allows up to remove MediaResource from the base class of HLSResource and MediaSourceResource.
Blocks: 1373160
Attachment #8902081 - Flags: review?(gsquelart)
Attachment #8902082 - Flags: review?(gsquelart)
Comment on attachment 8902081 [details]
Bug 1393386. P1 - make PinForSeek/UnpinForSeek pure virtual.

https://reviewboard.mozilla.org/r/173498/#review178846
Attachment #8902081 - Flags: review?(gsquelart) → review+
Comment on attachment 8902082 [details]
Bug 1393386. P2 - remove MediaDecoder::GetResource().

https://reviewboard.mozilla.org/r/173500/#review178848

You make it look too easy!
Attachment #8902082 - Flags: review?(gsquelart) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96a77311197a
P1 - make PinForSeek/UnpinForSeek pure virtual. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9b9102b84ebc
P2 - remove MediaDecoder::GetResource(). r=gerald
https://hg.mozilla.org/mozilla-central/rev/96a77311197a
https://hg.mozilla.org/mozilla-central/rev/9b9102b84ebc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.