1393386 - Remove MediaDecoder::GetResource()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

Blessed is MediaDecoder which is ignorant of MediaResource. This makes porting MediaDecoder to Servo easier.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

This also allows up to remove MediaResource from the base class of HLSResource and MediaSourceResource.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1393386. P1 - make PinForSeek/UnpinForSeek pure virtual.

Sub-classes should know how to pin/unpin the resource.

Review commit: https://reviewboard.mozilla.org/r/173498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173498/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1393386. P2 - remove MediaDecoder::GetResource().

Review commit: https://reviewboard.mozilla.org/r/173500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173500/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8902081 [details]
Bug 1393386. P1 - make PinForSeek/UnpinForSeek pure virtual.

https://reviewboard.mozilla.org/r/173498/#review178846

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8902082 [details]
Bug 1393386. P2 - remove MediaDecoder::GetResource().

https://reviewboard.mozilla.org/r/173500/#review178848

You make it look too easy!

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96a77311197a
P1 - make PinForSeek/UnpinForSeek pure virtual. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9b9102b84ebc
P2 - remove MediaDecoder::GetResource(). r=gerald

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/96a77311197a
https://hg.mozilla.org/mozilla-central/rev/9b9102b84ebc