1393397 - Hard to see Sidebars item in customize mode with Dark theme

Status: RESOLVED DUPLICATE of bug 1384686

(Firefox :: Theme, defect)

Description

[atlanto]

Sidebars item icon is affected by sidebar visibility. If sidebar is shown, the item is drawn dark on dark.

Comment 1

[atlanto]

Attachment: when sidebar is hidden, white icon - desirable

Comment 2

[atlanto]

Attachment: when sidebar is shown, black icon - undesirable

Comment 3

[:Gijs (he/him)]

Does this happen irrespective of the location of the button, or only when it's in the customization palette / "Drag your favorite items..."-labelled bit?

Comment 4

[Dão Gottwald [:dao]]

(In reply to :Gijs from comment #3)
> Does this happen irrespective of the location of the button, or only when
> it's in the customization palette / "Drag your favorite items..."-labelled
> bit?

Only in the palette. It comes from here:
http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/toolkit/themes/windows/global/toolbarbutton.css#69

Probably need to override this more explicitly with color: inherit; or something.

Comment 5

[:Gijs (he/him)]

Removing ni per comment #4.

Comment 6

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1393397 - Use the correct color for checked items in customize palette.

Review commit: https://reviewboard.mozilla.org/r/180374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180374/

Comment 7

[:Gijs (he/him)]

Comment on attachment 8908744 [details]
Bug 1393397 - Use the correct color for checked items in customize palette.

https://reviewboard.mozilla.org/r/180374/#review185712

Thanks!

Comment 8

[:Gijs (he/him)]

Comment on attachment 8908744 [details]
Bug 1393397 - Use the correct color for checked items in customize palette.

https://reviewboard.mozilla.org/r/180374/#review185714

::: browser/themes/shared/customizableui/customizeMode.inc.css:240
(Diff revision 1)
>  
>  #customization-palette .toolbarbutton-1 {
>    fill: currentColor;
>  }
>  
> +#customization-palette .toolbarbutton-1[checked="true"]:not([disabled="true"]) {

I wonder if this also works if instead of `#customization-palette` with a descendant selector you use:

```css
toolbarpaletteitem[place="palette"] > .toolbarbutton-1[checked="true"]:not([disabled="true"])
```

Comment 9

[Sam Foster [:sfoster] (he/him)]

Turns out this is a dupe of 1384686, where a more general fix for this just landed.