Hard to see Sidebars item in customize mode with Dark theme

RESOLVED DUPLICATE of bug 1384686

Status

()

Firefox
Theme
--
trivial
RESOLVED DUPLICATE of bug 1384686
11 months ago
10 months ago

People

(Reporter: atlanto, Unassigned)

Tracking

57 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

11 months ago
Sidebars item icon is affected by sidebar visibility. If sidebar is shown, the item is drawn dark on dark.
(Reporter)

Comment 1

11 months ago
Created attachment 8900658 [details]
when sidebar is hidden, white icon - desirable
(Reporter)

Comment 2

11 months ago
Created attachment 8900660 [details]
when sidebar is shown, black icon - undesirable

Comment 3

11 months ago
Does this happen irrespective of the location of the button, or only when it's in the customization palette / "Drag your favorite items..."-labelled bit?
Flags: needinfo?(euthanasia_waltz)
Whiteboard: [photon-visual][triage]

Updated

11 months ago
Whiteboard: [photon-visual][triage] → [photon-structure][triage]

Comment 4

11 months ago
(In reply to :Gijs from comment #3)
> Does this happen irrespective of the location of the button, or only when
> it's in the customization palette / "Drag your favorite items..."-labelled
> bit?

Only in the palette. It comes from here:
http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/toolkit/themes/windows/global/toolbarbutton.css#69

Probably need to override this more explicitly with color: inherit; or something.

Updated

11 months ago
Flags: qe-verify+
Priority: -- → P4
QA Contact: gwimberly
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]

Comment 5

11 months ago
Removing ni per comment #4.
Flags: needinfo?(euthanasia_waltz)
Status: UNCONFIRMED → NEW
status-firefox57: --- → affected
Ever confirmed: true
Comment hidden (mozreview-request)

Updated

10 months ago
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Priority: P4 → P1

Comment 7

10 months ago
mozreview-review
Comment on attachment 8908744 [details]
Bug 1393397 - Use the correct color for checked items in customize palette.

https://reviewboard.mozilla.org/r/180374/#review185712

Thanks!
Attachment #8908744 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 8

10 months ago
mozreview-review
Comment on attachment 8908744 [details]
Bug 1393397 - Use the correct color for checked items in customize palette.

https://reviewboard.mozilla.org/r/180374/#review185714

::: browser/themes/shared/customizableui/customizeMode.inc.css:240
(Diff revision 1)
>  
>  #customization-palette .toolbarbutton-1 {
>    fill: currentColor;
>  }
>  
> +#customization-palette .toolbarbutton-1[checked="true"]:not([disabled="true"]) {

I wonder if this also works if instead of `#customization-palette` with a descendant selector you use:

```css
toolbarpaletteitem[place="palette"] > .toolbarbutton-1[checked="true"]:not([disabled="true"])
```

Comment 9

10 months ago
Turns out this is a dupe of 1384686, where a more general fix for this just landed.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1384686

Updated

10 months ago
Assignee: sfoster → nobody
Flags: qe-verify+
Priority: P1 → --
QA Contact: gwimberly
Whiteboard: [reserve-photon-structure]
status-firefox57: affected → ---
QA Contact: Virtual
You need to log in before you can comment on or make changes to this bug.