Bookmarks and History subviews are cut off

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
9 months ago
9 months ago

People

(Reporter: Ovidiu, Assigned: Gijs)

Tracking

(Blocks: 1 bug)

57 Branch
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [reserve-photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

9 months ago
Created attachment 8900679 [details]
Screen Shot 2017-08-24 at 2.47.43 PM.png

[Affected versions]:

Nightly 57.0a1(2017-08-24)

[Affected platforms]:

Tested on Mac OS X 10.10 and Mac Os X 10.12, on other OSes the latest Nightly didn't land. I will update this bug after I test on the latest Nightly.

[Steps to reproduce]:

 Click on Menu -> library -> Bookmarks or History

[Actual result]:

The bookmarks are cut off.

[Expected result]:

The bookmarks are displayed correctly. 

Please see the attachment 

Note: This is a regression, on the Nightly from 2017-08-23 I can't reproduce this. I tried to use mozregression but I have some issues and I can't get a regression window.

Updated

9 months ago
Blocks: 1349210
No longer blocks: 1325171
Summary: Bookmarks and History dialog is cut off → Bookmarks and History subviews are cut off
Whiteboard: [photon-structure][triage]

Comment 1

9 months ago
Hmm, this could be a regression from bug 1391017 which moved toolbarbutton.bookmark-item { max-width: 13em; } from being directly in browser.css to a different place in toolbarbuttons.inc.css, so I guess it could take precedence over some other rule that ends up before this in browser.css.

Comment 2

9 months ago
Or maybe it's :not(#bookmarks-toolbar-placeholder) that boosts this rule's specificity.
(Assignee)

Comment 3

9 months ago
I can reproduce, but not a lot of stuff landed inbetween these 2 nightlies, so I'm puzzled as to what would have caused this... trying mozregression myself right now. Already tested turning stylo on/off, made no difference.
(Assignee)

Comment 4

9 months ago
(In reply to Dão Gottwald [::dao] from comment #1)
> Hmm, this could be a regression from bug 1391017 which moved
> toolbarbutton.bookmark-item { max-width: 13em; } from being directly in
> browser.css to a different place in toolbarbuttons.inc.css, so I guess it
> could take precedence over some other rule that ends up before this in
> browser.css.

Ah, this would be plausible. I'll see if I can confirm with mozregression.
(Assignee)

Comment 5

9 months ago
Yep, https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6ccd5cf829e2af1d068d2ac87e80bfe0687f9136&tochange=b45c8f18e2463f0f20130236e86aeb8f51b82b12 .

Testing with the style editor, reducing the specificity by removing the :not(...) fixes this.
Blocks: 1391017
(Assignee)

Comment 6

9 months ago
Patch incoming. Not really sure if max-width: none is more or less appropriate than unset, let me know if you feel strongly.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Priority: -- → P1
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Iteration: --- → 57.2 - Aug 29
Flags: qe-verify+
QA Contact: ovidiu.boca
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]

Comment 8

9 months ago
mozreview-review
Comment on attachment 8900696 [details]
Bug 1393411 - avoid setting the max-width of bookmark items with too great a specificity,

https://reviewboard.mozilla.org/r/172142/#review177406
Attachment #8900696 - Flags: review?(dao+bmo) → review+

Comment 9

9 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/109578ac95f6
avoid setting the max-width of bookmark items with too great a specificity, r=dao
(Assignee)

Updated

9 months ago
Duplicate of this bug: 1393527

Updated

9 months ago
Duplicate of this bug: 1393541

Comment 13

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/109578ac95f6
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
(Reporter)

Comment 14

9 months ago
I verified this on Mac OS X 10.10, Windows 10 x64 with Nightly 57.0a1(2017-08-25) and I can confirm the fix.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: qe-verify+

Updated

9 months ago
Duplicate of this bug: 1393794
You need to log in before you can comment on or make changes to this bug.