139343 - Clean up build warnings in nsComputedDOMStyle, nsROCSSPrimitiveValue

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P4)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Jst pinged me about these warnings he got.  They look harmless but we should
clean them up anyway.

nsComputedDOMStyle.cpp
e:\clean\mozilla\content\html\style\src\nsComputedDOMStyle.cpp(1675) : warning
C4244: 'argument' : conversion from 'int' to 'float', possible loss of data
e:\clean\mozilla\content\html\style\src\nsComputedDOMStyle.cpp(1788) : warning
C4244: 'argument' : conversion from 'int' to 'float', possible loss of data
e:\clean\mozilla\content\html\style\src\nsComputedDOMStyle.cpp(1838) : warning
C4244: 'argument' : conversion from 'float' to 'int', possible loss of data
e:\clean\mozilla\content\html\style\src\nsComputedDOMStyle.cpp(1968) : warning
C4244: 'argument' : conversion from 'float' to 'int', possible loss of data
e:\clean\mozilla\content\html\style\src\nsComputedDOMStyle.cpp(2279) : warning
C4244: 'argument' : conversion from 'unsigned int' to 'float', possible loss of data
e:\clean\mozilla\content\html\style\src\nsComputedDOMStyle.cpp(3012) : warning
C4244: 'argument' : conversion from 'float' to 'int', possible loss of data
e:\clean\mozilla\content\html\style\src\nsComputedDOMStyle.cpp(3076) : warning
C4244: 'argument' : conversion from 'float' to 'int', possible loss of data
e:\clean\mozilla\content\html\style\src\nsComputedDOMStyle.cpp(3121) : warning
C4244: 'argument' : conversion from 'float' to 'int', possible loss of data
e:\clean\mozilla\content\html\style\src\nsComputedDOMStyle.cpp(3169) : warning
C4244: 'argument' : conversion from 'float' to 'int', possible loss of data
e:\clean\mozilla\content\html\style\src\nsComputedDOMStyle.cpp(3787) : warning
C4244: 'argument' : conversion from 'float' to 'int', possible loss of data
e:\clean\mozilla\content\html\style\src\nsComputedDOMStyle.cpp(3791) : warning
C4244: 'argument' : conversion from 'float' to 'int', possible loss of data

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Proposed patch v1.0

I need someone to test this out since I don't see those warnings... jst?  :)

Comment 2

[Peter A Jonsson]

The warnings go away with this patch using gcc 3.0.4 on FreeBSD. I have not
tested any functionality, just building.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 80605 [details] [diff] [review]
Proposed patch v1.0

Actually, should we have a SetTwips(float) that converts to nscoord?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Sounds good to me....

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Alternate patch

Smaller patch.	Adds SetTwips(float aValue) to the RO PrimitiveValue so we
don't need to keep adding nscoord(foo) to computed style in the future.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 80676 [details] [diff] [review]
Alternate patch

sr=jst

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 80676 [details] [diff] [review]
Alternate patch

r=bzbarsky

Death to build warnings!

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fixed