1393434 - Ubuntu Modifications determines an infinite loop of requests to restart the browser

Status: RESOLVED WONTFIX

(WebExtensions :: General, defect)

Description

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

[Affected versions]:
 Fx 56.0b3 Developer Edition
 Fx 56.0b4 Developer Edition
 Fx 56.0b5 Developer Edition
 
[Affected platforms]:
 Ubuntu 14.04 LTS x64
 Ubuntu 16.04 LTS x64

[Steps to reproduce]:
 1. Open Firefox with a clean profile.
 2. Go to hamburger menu and click on the "Ubuntu Modifications" notification.
 3. Enable the "Ubuntu Modifications" from the door hanger and restart the browser.
 4. Go to a page and wait (i.e. www.amazon.com ).

[Expected result]:
 The broswer works accordingly.

[Actual result]:
 The doorhanger with "You should restart Firefox Developer Edition now to install updates" is displayed, even after the user restarts the browser.

[Regression range]:
 Last Good: Fx 56.0b2 Developer edition (build ID: 20170810180547)
 First Bad: Fx 56.0b3 Developer edition (build ID: 20170815141045)
 Pushlog: https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=2638feb177dd&tochange=efabe9b3a88e

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

Chris, can you look into this? I also noticed on bug 1364978 you said there were plans to retire the add-on. Is that still the case?

Comment 2

[Mike Kaply [:mkaply]]

This doesn't seem related to the add-on specifically. My wager is this is related to the changes for bug 1372448 to make sideloaded add-ons work again.

How is the Ubuntu add-on installed?

Comment 3

[Mike Kaply [:mkaply]]

bug 1372448 is in this regression range.

Comment 4

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

As soon as you start Firefox, freshly installed with a clean profile there is a notification in the hamburger menu. 
Once you click it the notification states : " Ubuntu Modifications added to Firefox! ".

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Mike Kaply [:mkaply] from comment #2)
> This doesn't seem related to the add-on specifically. My wager is this is
> related to the changes for bug 1372448 to make sideloaded add-ons work again.

Andrew, did you test the fix in bug 1372448 on Ubuntu? Could you take a look at this regression?

Comment 6

[Andrew Swan [:aswan]]

I would be surprised if there's something specific to Ubuntu here.  But it sounds like the extension in question is not restartless which means it will stop working in 57.  Given that, I can't justify spending much time on this...

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

We haven't seen any other reports of this issue and the extension does not look like it's very widespread. Too late to fix this in 56.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Resolving as we won't take a fix for 56 at this point and 57 will disable this add-on anyway.