Closed Bug 1393435 Opened 2 years ago Closed 2 years ago

Remove unnecessary inclusions of nsExceptionHandler.h and CrashReporterHost.h

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1323979 +++

While working on bug 1323979 I've noticed that touching nsExceptionHandler.h rebuilds half of our tree which is... unpleasant to say the least. I've also noticed that there's quite a few inclusions that are either unnecessary or redundant so we should get rid of them.

(on a side note, it seems to me that the includehell bug has received too little love as of late, it would be time to pick it up again before our preprocessor output spills out of our computers and onto the floor)
I've got a patch ready for this but I haven't checked if it builds on all platforms yet, the try run is here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a86643d5deff41570541e044e2d04013b6834800
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment on attachment 8900741 [details]
Bug 1393435 - Remove unnecessary inclusions of the crash reporter header files;

https://reviewboard.mozilla.org/r/172204/#review177540

Yay, less header coupling. :) Thanks!
Attachment #8900741 - Flags: review?(mconley) → review+
Thanks for the quick review! The try run looks green, landing this.
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a516dafb1006
Remove unnecessary inclusions of the crash reporter header files; r=mconley
https://hg.mozilla.org/mozilla-central/rev/a516dafb1006
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.