1393449 - Replace usage of quitter extension with Marionette

Status: NEW

(Firefox Build System :: General, enhancement)

Description

[(not currently active) Ted Mielczarek]

We've got this quitter extension in the tree that I wrote ages ago (bug 641829) to replace the use of enablePrivilege for our PGO profiling run script:
https://dxr.mozilla.org/mozilla-central/source/tools/quitter

Its sole purpose is to provide a `quit` API to content pages. It's still used there:
https://dxr.mozilla.org/mozilla-central/rev/f0abd25e1f4acced652d180c34b7c9eda638deb1/build/pgo/profileserver.py#50

as well as in our Valgrind tests (which run the same set of pages as the PGO profiling run):
https://dxr.mozilla.org/mozilla-central/rev/f0abd25e1f4acced652d180c34b7c9eda638deb1/build/valgrind/mach_commands.py#76

We should change both of those to use Marionette to start and shutdown the browser and get rid of quitter.

Comment 1

[Gregory Szorc [:gps]]

Will the use of Marionette pull in enough "new" code in the Firefox process that it will skew profiling optimizations towards code that doesn't run in "normal" installs? I guess we'll find out when we change this and measure the results.

Comment 2

[Kim Moir [:kmoir] ET]

How much time would this take to remove?  I'm wondering since bug 1442741 is asking for the quitter tool to be signed and landed whenever it changes.  It looks like it hasn't changed since last year.  (I'm just asking in general how much time it would take, not specifically who should do it)

Comment 3

[(not currently active) Ted Mielczarek]

I don't think it'd be more than a couple of days work to fix these scripts to use Marionette.