Closed Bug 1393477 Opened 7 years ago Closed 7 years ago

Large logos appear on doorhangers

Categories

(Firefox for Android Graveyard :: General, defect)

57 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox55 unaffected, firefox56 unaffected, firefox57 verified)

VERIFIED FIXED
Firefox 57
Tracking Status
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- verified

People

(Reporter: ohorvath, Assigned: jwu)

Details

(Whiteboard: [FNC][SPT57.3][INT])

Attachments

(5 files)

Devices:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
HTC Desire 820 (Android 6.0.1)
Motorola Nexus 6 (Android 7.0)

Build: Nightly 57.0a1 (2017-08-24);

Steps to reproduce:
1. Go to mapquest.com / wizzair.com / twitter.com
2. Observe the logo on the location and password doorhangers.
3. If at first they look ok, refresh the page and try again.

Expected result:
On the password doorhanger, the logo should not appear (as it was before).
On the location doorhanger, the logo should be smaller.

Actual result:
See screenshots.
Hi Jwu
Could you please take a look?
Flags: needinfo?(topwu.tw)
We would fix large logo issue asap, but I don't think logo showed in password doorhanger is a bug. The screenshot is a captured in release version and you can see the logo in doorhanger.

Since I cannot think of any benefit to hide logo in password doorhanger, I would like to file a patch only for fixing large logo.
Flags: needinfo?(topwu.tw)
Assignee: nobody → topwu.tw
Comment on attachment 8903068 [details]
Bug 1393477 - Resize favicon shown in doorhanger.

https://reviewboard.mozilla.org/r/174844/#review180690

Thanks. Do you know why it gets so large till now?
Comment on attachment 8903068 [details]
Bug 1393477 - Resize favicon shown in doorhanger.

https://reviewboard.mozilla.org/r/174844/#review180710
Attachment #8903068 - Flags: review?(cnevinchen) → review+
Comment on attachment 8903068 [details]
Bug 1393477 - Resize favicon shown in doorhanger.

https://reviewboard.mozilla.org/r/174844/#review180690

I think it's a side effect of bug 1383736 that we save large favicons(112 * 112dp) in storage.
Pushed by topwu.tw@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a62b77c74881
Resize favicon shown in doorhanger. r=nechen
https://hg.mozilla.org/mozilla-central/rev/a62b77c74881
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Whiteboard: [FNC][SPT57.3][INT]
tracking-fennec: ? → ---
Verified as fixed in Beta 57.0b3.
Devices:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
LG G4 (Android 6.0)
Lenovo A536 (Android 4.4.2)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.