1393477 - Large logos appear on doorhangers

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Oana Horvath [:ohorvath]]

Attachment: Screenshot_20170824-175132.png

Devices:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
HTC Desire 820 (Android 6.0.1)
Motorola Nexus 6 (Android 7.0)

Build: Nightly 57.0a1 (2017-08-24);

Steps to reproduce:
1. Go to mapquest.com / wizzair.com / twitter.com
2. Observe the logo on the location and password doorhangers.
3. If at first they look ok, refresh the page and try again.

Expected result:
On the password doorhanger, the logo should not appear (as it was before).
On the location doorhanger, the logo should be smaller.

Actual result:
See screenshots.

Comment 1

[Oana Horvath [:ohorvath]]

Attachment: Screenshot_20170824-173542.png

Comment 2

[Oana Horvath [:ohorvath]]

Attachment: Screenshot_20170824-174445.png

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Hi Jwu
Could you please take a look?

Comment 4

[Jing-wei Wu [:jwu]]

Attachment: Logo in password doorhanger in release

We would fix large logo issue asap, but I don't think logo showed in password doorhanger is a bug. The screenshot is a captured in release version and you can see the logo in doorhanger.

Since I cannot think of any benefit to hide logo in password doorhanger, I would like to file a patch only for fixing large logo.

Comment 5

[Jing-wei Wu [:jwu]]

Attachment: Bug 1393477 - Resize favicon shown in doorhanger.

Review commit: https://reviewboard.mozilla.org/r/174844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174844/

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8903068 [details]
Bug 1393477 - Resize favicon shown in doorhanger.

https://reviewboard.mozilla.org/r/174844/#review180690

Thanks. Do you know why it gets so large till now?

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8903068 [details]
Bug 1393477 - Resize favicon shown in doorhanger.

https://reviewboard.mozilla.org/r/174844/#review180710

Comment 8

[Jing-wei Wu [:jwu]]

Comment on attachment 8903068 [details]
Bug 1393477 - Resize favicon shown in doorhanger.

https://reviewboard.mozilla.org/r/174844/#review180690

I think it's a side effect of bug 1383736 that we save large favicons(112 * 112dp) in storage.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a62b77c74881
Resize favicon shown in doorhanger. r=nechen

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a62b77c74881

Comment 11

[Oana Horvath [:ohorvath]]

Verified as fixed in Beta 57.0b3.
Devices:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
LG G4 (Android 6.0)
Lenovo A536 (Android 4.4.2)