Closed Bug 1393483 Opened 2 years ago Closed 2 years ago

Correctly pass cancel token to _onResultRow

Categories

(Toolkit :: Places, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: simon.lindholm10, Assigned: simon.lindholm10)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

No description provided.
Attachment #8900767 - Flags: review?(mak77)
Out of interest, what's the functional issue here? Should it be covered by tests?
I believe it's just a harmless JS exception when a new awesomebar search gets kicked off at the wrong time.  It's pretty hard to test, because it depends on timing.
Comment on attachment 8900767 [details] [diff] [review]
Correctly pass cancel token to _onResultRow

Review of attachment 8900767 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, sigh, good catch.
Attachment #8900767 - Flags: review?(mak77) → review+
it's not harmless actually, we don't pass cancel down to the method, that means queries are not canceled properly.
Keywords: checkin-needed
Priority: -- → P1
Whiteboard: [fxsearch]
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d79669571987
Correctly pass cancel token to _onResultRow. r=mak
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d79669571987
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.