Correctly pass cancel token to _onResultRow

RESOLVED FIXED in Firefox 57

Status

()

Toolkit
Places
P1
normal
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: Simon Lindholm, Assigned: Simon Lindholm)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

10 months ago
Created attachment 8900767 [details] [diff] [review]
Correctly pass cancel token to _onResultRow
Attachment #8900767 - Flags: review?(mak77)
Out of interest, what's the functional issue here? Should it be covered by tests?
(Assignee)

Comment 3

10 months ago
I believe it's just a harmless JS exception when a new awesomebar search gets kicked off at the wrong time.  It's pretty hard to test, because it depends on timing.

Comment 4

10 months ago
Comment on attachment 8900767 [details] [diff] [review]
Correctly pass cancel token to _onResultRow

Review of attachment 8900767 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, sigh, good catch.
Attachment #8900767 - Flags: review?(mak77) → review+

Comment 5

10 months ago
it's not harmless actually, we don't pass cancel down to the method, that means queries are not canceled properly.

Updated

10 months ago
Keywords: checkin-needed
Priority: -- → P1
Whiteboard: [fxsearch]

Comment 6

10 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d79669571987
Correctly pass cancel token to _onResultRow. r=mak
Keywords: checkin-needed

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d79669571987
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.