Closed Bug 1393504 Opened 7 years ago Closed 7 years ago

Truncate/ellipsize custom tabs action bar title to avoid misleading titles

Categories

(Firefox for Android Graveyard :: Custom Tabs, defect, P1)

53 Branch
All
Android
defect

Tracking

(fennec+, firefox55 unaffected, firefox56 unaffected, firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
fennec + ---
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: droeh, Assigned: droeh)

References

Details

Attachments

(2 files)

We probably want to ellipsize the action bar title from the left or something similar to avoid misleading titles like this: https://twitter.com/ericlaw/status/900429796240277504
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Sorry - I overlooked that fact that this was about custom tabs specifically.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Status: REOPENED → NEW
Assignee: nobody → droeh
Blocks: customtabs
Priority: -- → P2
Attached image ellipsize.png
Here's a screenshot of what this looks like. Kinda sucks, but may help the security situation a bit. I think we probably want a more involved solution as in bug 1271998. Nevin do you folks want to take this over?
Flags: needinfo?(cnevinchen)
Comment on attachment 8907090 [details]
Bug 1393504 - Ellipsize URL in Custom Tabs at the beginning

https://reviewboard.mozilla.org/r/178804/#review184118
Attachment #8907090 - Flags: review?(cnevinchen) → review+
Hi Wesly, Joe
Please help prioritize this.
Flags: needinfo?(wehuang)
Flags: needinfo?(jcheng)
Flags: needinfo?(cnevinchen)
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89c9628b2c8d
Ellipsize URL in Custom Tabs in the middle r=nechen
https://hg.mozilla.org/mozilla-central/rev/89c9628b2c8d
Status: NEW → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Flags: needinfo?(wehuang)
Flags: needinfo?(jcheng)
Component: General → Custom Tabs
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.