Vertical line artifact when the tab strip is overflowing at 150% DPI

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
5 months ago
4 months ago

People

(Reporter: Itiel, Assigned: dao)

Tracking

({regression, rtl})

unspecified
Firefox 57
regression, rtl
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 unaffected, firefox57 verified)

Details

(Whiteboard: [reserve-photon-visual])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

5 months ago
Created attachment 8900800 [details]
Screenshot

This is a regression, the range is 2017-08-23 to 2017-08-24.

Environment:
Windows 10 x86
Latest Nightly (2017-08-24)

STR:
1. Open many tabs, so the tab strip would be overflowing
2. Observe the surronding area of the '<' and the '>' button on the tab strip

AR:
If the tab strip is NOT scrolled to the very start/end, you'd be able to see a vercial line artifact about ~1cm close to the '<' and the '>' button.

ER:
It shouldn't exist.


2017-08-24T19:12:33: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=b07dea0e4ffd7f0000ec4029943bebcf91e7ffc2&full=1
2017-08-24T19:12:35: DEBUG : Found commit message:
Bug 1341102: Revendor rust dependencies. r=me

On a CLOSED TREE

MozReview-Commit-ID: BoEbixf4mIK


2017-08-24T19:12:35: INFO : The bisection is done.
2017-08-24T19:12:35: INFO : Stopped


See attached.
I doubt this can be done by that commit. That commit unbusted the build, so we should probably look at the few ones that landed right before, between that and the relevant servo PR.
No longer blocks: 1341102

Updated

5 months ago
Component: Tabbed Browser → Untriaged
Product: Firefox → Core
Summary: Vercial line artifact when the tab strip is overflowing → Vertical line artifact when the tab strip is overflowing

Updated

5 months ago
Keywords: rtl
Sometimes such kind of lines are caused by a graphics bug, but Bug 1392622 may also be related.
Component: Untriaged → Tabbed Browser
Product: Core → Firefox
See Also: → bug 1392622

Comment 3

5 months ago
(In reply to Kohei Yoshino [:kohei] from comment #2)
> Sometimes such kind of lines are caused by a graphics bug, but Bug 1392622
> may also be related.

Unlikely since we stopped having curvy tabs that have multiple parts. Why did you put this back in Tabbed Browser? We just don't know what's causing this, but given that the artifacts appear next to the scroll button shadow, I'm pretty ready to bet there's just a graphics/layout-related issue. But as long as we don't know, it should just live in untriaged.


ItielMaN, can you try again to find a regression window?
Component: Tabbed Browser → Untriaged
Flags: needinfo?(itiel_yn8)
(Reporter)

Comment 4

5 months ago
@kohei: This isn't RTL-only bug. It's reproducible also on LTR builds.

(In reply to :Gijs (out until Sep 1, expect no replies to requests) from comment #3)
> ItielMaN, can you try again to find a regression window?

Tried that already twice before I opened this bug (since the commit didn't seem to be related to the bug) but I got the same results.
Anyway, I've tried finding again a regression window, and the same commit appeared as the culprit.
Flags: needinfo?(itiel_yn8)

Comment 5

5 months ago
User Agent: Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0
Version: 57.0a1, Build ID: 20170904220027

Hello,

I have tested your issue on latest Nightly build and could not reproduce it. I have opened multiple tabs, and at the surrounding area of the "<" and the ">", that vertical line artifact didn't appear .

Do you have any Firefox Theme installed or do you have a custom Windows Theme?
Also, can you please retest this using a new clean Firefox profile, maybe even safe mode, to eliminate custom settings as a possible cause (https://goo.gl/AR5o9d) and report back the results?
Flags: needinfo?(itiel_yn8)
(Reporter)

Comment 6

5 months ago
(In reply to Cristina Badescu from comment #5)
> User Agent: Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101
> Firefox/57.0
> Version: 57.0a1, Build ID: 20170904220027
> 
> Hello,
> 
> I have tested your issue on latest Nightly build and could not reproduce it.
> I have opened multiple tabs, and at the surrounding area of the "<" and the
> ">", that vertical line artifact didn't appear .
> 
> Do you have any Firefox Theme installed or do you have a custom Windows
> Theme?
> Also, can you please retest this using a new clean Firefox profile, maybe
> even safe mode, to eliminate custom settings as a possible cause
> (https://goo.gl/AR5o9d) and report back the results?

The regression window reported in comment 0 was taken from Mozregression using a clean profile each time.
Nightly theme is the default one.
Windows 10 x86 theme is normal, blue-colored (as it can be seen in the attached screenshot).
If it matters, the monitor is 24", 150% DPI, resolution set to 1920x1080.
Flags: needinfo?(itiel_yn8)

Comment 7

5 months ago
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Firefox: 57.0a1; Build ID: 20170905100117

Hello,

I managed to reproduce the issue on latest Nightly, using 150% DPI and resolution set to 1920x1080. 
I've ran a mozregression to find the bug that causes this. Here are the results:

Last good revision: e2707fdbeb05ec6eae648757b71efca49b0eaa4f
First bad revision: b07dea0e4ffd7f0000ec4029943bebcf91e7ffc2
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e2707fdbeb05ec6eae648757b71efca49b0eaa4f&tochange=b07dea0e4ffd7f0000ec4029943bebcf91e7ffc2

Dao, can you please take a look here and see if the results are related? I think this bug #1391743 might be related.
status-firefox55: --- → unaffected
status-firefox56: --- → affected
status-firefox-esr52: --- → unaffected
Component: Untriaged → Theme
Flags: needinfo?(dao+bmo)
(Assignee)

Updated

5 months ago
Blocks: 1391743
Flags: needinfo?(dao+bmo) → qe-verify+
Priority: -- → P3
See Also: bug 1392622
Summary: Vertical line artifact when the tab strip is overflowing → Vertical line artifact when the tab strip is overflowing at 150% DPI
Whiteboard: [reserve-photon-visual]
(Assignee)

Comment 8

5 months ago
The problem here is that the CSS border and background scale differently.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Duplicate of this bug: 1396853

Updated

5 months ago
Iteration: --- → 57.3 - Sep 19
QA Contact: ovidiu.boca
(Reporter)

Comment 11

5 months ago
This bug is reproducible also at 125% and 175%.
Comment on attachment 8904983 [details]
Bug 1393505 - Prevent the overflow indicator background from repeating when it doesn't fill the whole element due to the border scaling differently.

https://reviewboard.mozilla.org/r/176824/#review181918

Sorry took a while to reproduce, looks good thanks
Attachment #8904983 - Flags: review?(dharvey) → review+

Comment 13

5 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b0e6ed5b2a0
Prevent the overflow indicator background from repeating when it doesn't fill the whole element due to the border scaling differently. r=daleharvey
https://hg.mozilla.org/mozilla-central/rev/3b0e6ed5b2a0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
(Reporter)

Comment 15

4 months ago
Verified fixed on tested 125%, 150% and 175% DPI.
Status: RESOLVED → VERIFIED
(Reporter)

Updated

4 months ago
status-firefox57: fixed → verified

Updated

4 months ago
Flags: qe-verify+
status-firefox56: affected → unaffected
You need to log in before you can comment on or make changes to this bug.