Fix Unused Variable Warnings in toolkit/

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [tor])

Attachments

(1 attachment)

No description provided.
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c8bcf093d193ee9c247e7015076daaa911d48c5

(Build will fail but the warnings should be gone)
Attachment #8900836 - Flags: review?(bugs)
Comment on attachment 8900836 [details]
Bug 1393538 Clean up unused variables in toolkit/

https://reviewboard.mozilla.org/r/172282/#review177880
Attachment #8900836 - Flags: review?(bugs) → review+
Blocks: 1393487
Keywords: checkin-needed
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cd8884df2c24
Clean up unused variables in toolkit/ r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cd8884df2c24
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
No longer blocks: 1330608
Blocks: 1394433
Would nsNativeAppSupportWin.cpp have worked with MOZ_MAYBE_UNUSED instead? Perhaps it wasn't necessary to re-work the MOZ_UNUSED_ATTRIBUTE. It looks a bit awkward to move it outside of the specific static-assert use case (these kinds of things would generally go into Attributes.h) and also now this comment is orphaned: https://hg.mozilla.org/mozilla-central/rev/cd8884df2c24#l1.32
Blocks: 1433971
You need to log in before you can comment on or make changes to this bug.