Closed
Bug 1393538
Opened 7 years ago
Closed 7 years ago
Fix Unused Variable Warnings in toolkit/
Categories
(Toolkit :: General, enhancement)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
(Whiteboard: [tor])
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c8bcf093d193ee9c247e7015076daaa911d48c5 (Build will fail but the warnings should be gone)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 3•7 years ago
|
||
Full try run to be safe: https://treeherder.mozilla.org/#/jobs?repo=try&revision=417a56abc3d50bab7e4c2b33f7b7de7ec50a0425
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8900836 -
Flags: review?(bugs)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 5•7 years ago
|
||
That definetly broke, let's try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7eea2aec09c481a7c485e04836c4f73da496f598
| Comment hidden (mozreview-request) |
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8900836 [details] Bug 1393538 Clean up unused variables in toolkit/ https://reviewboard.mozilla.org/r/172282/#review177880
Attachment #8900836 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Updated•7 years ago
|
Blocks: 1393487
Keywords: checkin-needed
Pushed by philringnalda@gmail.com: https://hg.mozilla.org/integration/autoland/rev/cd8884df2c24 Clean up unused variables in toolkit/ r=smaug
Keywords: checkin-needed
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cd8884df2c24
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Comment 10•7 years ago
|
||
Would nsNativeAppSupportWin.cpp have worked with MOZ_MAYBE_UNUSED instead? Perhaps it wasn't necessary to re-work the MOZ_UNUSED_ATTRIBUTE. It looks a bit awkward to move it outside of the specific static-assert use case (these kinds of things would generally go into Attributes.h) and also now this comment is orphaned: https://hg.mozilla.org/mozilla-central/rev/cd8884df2c24#l1.32
You need to log in
before you can comment on or make changes to this bug.
Description
•