Closed Bug 1393538 Opened 3 years ago Closed 3 years ago

Fix Unused Variable Warnings in toolkit/

Categories

(Toolkit :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor])

Attachments

(1 file)

Comment on attachment 8900836 [details]
Bug 1393538 Clean up unused variables in toolkit/

https://reviewboard.mozilla.org/r/172282/#review177880
Attachment #8900836 - Flags: review?(bugs) → review+
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cd8884df2c24
Clean up unused variables in toolkit/ r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cd8884df2c24
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Would nsNativeAppSupportWin.cpp have worked with MOZ_MAYBE_UNUSED instead? Perhaps it wasn't necessary to re-work the MOZ_UNUSED_ATTRIBUTE. It looks a bit awkward to move it outside of the specific static-assert use case (these kinds of things would generally go into Attributes.h) and also now this comment is orphaned: https://hg.mozilla.org/mozilla-central/rev/cd8884df2c24#l1.32
You need to log in before you can comment on or make changes to this bug.