1393547 - missing nsACString declaration in mozilla/widget/nsPrimitiveHelpers.h

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[:aceman]

I get build failure on current trunk saying:

In file included from mozilla/widget/nsPrimitiveHelpers.cpp:23:0,
                 from widget/Unified_cpp_widget2.cpp:2:
mozilla/widget/nsPrimitiveHelpers.h:23:46: error: ‘nsACString’ does not name a type
   static void CreatePrimitiveForData ( const nsACString& aFlavor, const void* aDataBuff,
                                              ^
mozilla/widget/nsPrimitiveHelpers.h:33:47: error: ‘nsACString’ does not name a type
   static void CreateDataFromPrimitive ( const nsACString& aFlavor, nsISupports* aPrimitive, 
                                               ^
mozilla/widget/nsPrimitiveHelpers.h:50:58: error: ‘nsACString’ does not name a type
   static nsresult ConvertPlatformToDOMLinebreaks ( const nsACString& inFlavor, void** ioData, int32_t* ioLengthInBytes ) ;
                                                          ^
This started just several days ago. The file is missing inclusion of the nsACString declaration.

Comment 1

[:aceman]

Attachment: patch

This makes the compilation progress past that file.

Comment 2

[Jorg K (CEST = GMT+2)]

Looks similar to bug 1389408 / bug 1387912 and most likely only shows up for some due to unified-compilation dependencies.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8900853 [details] [diff] [review]
patch

Review of attachment 8900853 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, aceman. Seems okay, but we should probably get somebody from widget/ to sign off on this.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Thanks jimm!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad79eeeadb0a
Add missing nsACString declarations in widget/nsPrimitiveHelpers.h. r=mconley

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad79eeeadb0a