Closed Bug 1393548 Opened 7 years ago Closed 7 years ago

send tabs page update

Categories

(www.mozilla.org :: Pages & Content, enhancement)

Production
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: erenaud, Assigned: agibson)

References

Details

Attachments

(5 files)

      No description provided.
Attached image Tabs_01.png
Mobile CTA variant
Attached image Tabs_02.png
Sign in or create a firefox account variant
Attached image tabs_03.png
Download Firefox variant
Blocks: 1383417
Assignee: nobody → agibson
Status: NEW → ASSIGNED
Attached file GitHub pull request
Demo: https://bedrock-demo-agibson.us-west.moz.works/en-US/firefox/features/send-tabs/

CTA states to test:

1. Firefox signed into Sync
2. Firefox signed out of Sync
3. Non-Firefox
4. Firefox for iOS
5. Firefox for Android
6. Old Firefox (v < 31)

Note: to test signed in/out functionality on Desktop you will need to enable uitour for https://bedrock-demo-agibson.us-west.moz.works/ using these instructions: http://bedrock.readthedocs.io/en/latest/uitour.html#local-development

Gareth, can you please take a look at the CTA's here to make sure we get them tracked in GA? If you have any querstions or need any changes, please let me know.
Flags: needinfo?(garethcull.bugs)
I'm not sure who this falls on, but it would be really great if this page could actually inform a user on how to send a tab. :/
(In reply to Jon Petto [:jpetto] from comment #6)
> I'm not sure who this falls on, but it would be really great if this page
> could actually inform a user on how to send a tab

Definitely, the same could be said for nearly every feature page we have. We may need to save that for anothe bug though.
Flags: needinfo?(garethcull.bugs) → needinfo?(wes.contreras)
Is there a way to manually force a particular state for testing? Especially for iOS, Android, and older Firefox versions.
Flags: needinfo?(agibson)
(In reply to Wes Contreras from comment #8)
> Is there a way to manually force a particular state for testing? Especially
> for iOS, Android, and older Firefox versions.

If you inspect the DOM using Dev Tools you can force individual page states by setting the following class name on the <body> element:

Firefox for Android: class="html-ltr state-fx-android"
Firefox for iOS: class="html-ltr state-fx-ios"
Old Firefox: class="html-ltr state-fx-30-older"
Flags: needinfo?(agibson)
Analytics tagging looks good, firing network calls. Screenshot of GA events for send-tabs page at moz.works attached.
Flags: needinfo?(wes.contreras)
Fixed in https://github.com/mozilla/bedrock/commit/a34e6cba243a17c1837fbdd17fcef832d25179de
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: