1393556 - firefox-55.0.2/media/webrtc/trunk/webrtc/video/replay.cc:87: bad test ?

Status: RESOLVED WONTFIX

(Core :: WebRTC: Audio/Video, defect)

Description

[David Binderman]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170613080647

Steps to reproduce:

firefox-55.0.2/media/webrtc/trunk/webrtc/video/replay.cc:87]: (warning) Logical disjunction always evaluates to true: extension_id >= -1 || extension_id < 15.

Source code is

static bool ValidateRtpHeaderExtensionId(const char* flagname,
                                         int32_t extension_id) {
  return extension_id >= -1 || extension_id < 15;
}

Comment 1

[Dan Minor [:dminor]]

Thank you for your report. I agree with your assessment, but this function is present in a portion of the webrtc.org library that Firefox does not build or use so fixing this is a low priority for us.

I would suggest filing a bug against webrtc.org (https://bugs.chromium.org/p/webrtc/issues/list).

Once fixed upstream, it will be imported into Firefox in a future update.