All IdleRunnables have the same runnable name

RESOLVED FIXED in Firefox 57

Status

()

Core
XPCOM
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: mystor, Assigned: mystor)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
One of the highest ranked runnable types for >2s hangs on the BHR dashboard right now is `IdleRunnable`, which is unfortunate, as it's a very large group of different runnables.

I think it would be nice if `IdleRunnable` accepted a name argument in its constructor, and required its subclasses to provide more useful names.
(Assignee)

Comment 1

4 months ago
How reasonable would this be to do farre?
Flags: needinfo?(afarre)
(Assignee)

Comment 2

4 months ago
Created attachment 8900928 [details] [diff] [review]
Name all IdleTaskRunner runnables

This should make it easier to tell these runnables apart when they appear in BHR - as currently they all appear as a single bucket.
Attachment #8900928 - Flags: review?(bugs)
(In reply to Michael Layzell [:mystor] from comment #1)
> How reasonable would this be to do farre?

I like this a lot!
Flags: needinfo?(afarre)
Attachment #8900928 - Flags: review?(bugs) → review+
(Assignee)

Updated

4 months ago
Assignee: nobody → michael

Comment 4

4 months ago
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/19c5a66904af
Name all IdleTaskRunner runnables, r=smaug

Comment 5

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/19c5a66904af
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.