Closed
Bug 1393581
Opened 7 years ago
Closed 7 years ago
All IdleRunnables have the same runnable name
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
Details
Attachments
(1 file)
|
9.99 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
One of the highest ranked runnable types for >2s hangs on the BHR dashboard right now is `IdleRunnable`, which is unfortunate, as it's a very large group of different runnables. I think it would be nice if `IdleRunnable` accepted a name argument in its constructor, and required its subclasses to provide more useful names.
|
Assignee | |
Comment 2•7 years ago
|
||
This should make it easier to tell these runnables apart when they appear in BHR - as currently they all appear as a single bucket.
Attachment #8900928 -
Flags: review?(bugs)
|
||
Comment 3•7 years ago
|
||
(In reply to Michael Layzell [:mystor] from comment #1) > How reasonable would this be to do farre? I like this a lot!
Flags: needinfo?(afarre)
|
||
Updated•7 years ago
|
Attachment #8900928 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → michael
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/19c5a66904af Name all IdleTaskRunner runnables, r=smaug
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/19c5a66904af
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•