Closed Bug 1393652 Opened 7 years ago Closed 4 years ago

[es5 migration] index settings being overwritten during reindexing

Categories

(Socorro :: Infra, task, P3)

Tracking

(Not tracked)

RESOLVED INACTIVE

People

(Reporter: miles, Unassigned)

References

(Blocks 1 open bug)

Details

Index level settings appear to have been overwritten during the reindexing process.

I don't see why this should happen, and it it confusing that it is happening. It's possible that these indices were simply created with the wrong settings, but that doesn't make sense (the index creation script [1] is sound).

Related: see bug 1393650 for information on mapping settings being overwritten.

[1] https://pastebin.mozilla.org/9030548, see index creation payload attachments on bug 1322630.
I fleshed this out a bit here: https://bugzilla.mozilla.org/show_bug.cgi?id=1322630#c49

One important thing to consider is that "What's the harm?" If fields are added into ES 5, it's unfortunate but quite harmless. We don't query them anyway because they're not in super_search_fields.json. 
Also in that comment 49 I point out that at least certain fields' mappings don't change due to reindexing. 

My point is that among all the other more pressing things (*), getting in extra fields we don't really care for/want isn't a terrible price to pay. In fact, it might even be a good thing (**). 


(*) Conversions from "0"/"1" to true booleans & the file we use to create the mapping being at odds with what we have in super_search_fields.json
(**) Our pattern is that we store pretty much everything in ES. There's a view in the Admin to list all the unique fields that are in ES but not in Super Search Fields. And for each one, that gives you an opportunity to add it to Super Search Fields "now" and as soon as it's added you can query stuff that's been put into ES for the last couple months/weeks.
Making this a P2 to look into.
Priority: -- → P2

Bumping down to P3 until after we look into bug #1568601.

Priority: P2 → P3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.