Closed Bug 1393668 Opened 2 years ago Closed 2 years ago

Should highlight Screenshots page action button on the https://screenshots.firefox.com for the onboarding Screenshots tour

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: Fischer, Unassigned)

References

Details

Attachments

(1 file)

The Page Action is hidden on about: pages(See bug 1388835) so we should highlight Screenshots page action button on the https://screenshots.firefox.com
Whiteboard: [photon-onboarding]
Hi Verdi,

When loading https://screenshots.firefox.com/#hello, the screenshots#hello page would show its own tutorial (please load with Nightly, the tutorial won't show on FF55), i am not sure if that would confuse users if we just highlighted the Screenshots page action button on this page.

Another possible candidate pages are the screenshots#how-screenshots-works (https://screenshots.firefox.com/#how-screenshots-works). However, again, not sure if that would confuse users if we just highlighted the Screenshots page action button on this page. This page is a page for users to scroll to read some introductions. Maybe it would distract users by giving them too actions at the same time: reading introductions + trying highlighted Screenshots page action button.

Maybe we need to update some flow on the screenshots#hello page or the screenshots#how-screenshots-works page to make highlighting Screenshots page action button a better integration on the target page.

How do you think?

Thanks
Flags: needinfo?(mverdi)
That's probably more a question for the designer of the Firefox Screenshots site, but I don't know who I should ni in that case.
Attached image screenshots-tour.jpg
This is what I was hoping we could do:
1. User clicks the "Open Screenshots Website" button in the overlay.
2. A new tab is opened to https://screenshots.firefox.com which automatically expands the page actions menu and hightlights the screenshots button.
3. The user then clicks the screenshots button and if they've not used screenshots before the tutorial shows up or if they have used it before the screenshots UI is invoked (this is the current behavior for clicking the screenshots button while on this website).
Flags: needinfo?(mverdi)
The /#hello behavior was specifically designed for this kind of onboarding, so I think we should simply build off that.

Note the slides that are displayed are actually displayed by the add-on, and so they can display whatever is appropriate for that version. Technically it shouldn't be hard to trigger other behavior at that moment, such as highlighting the page action.

It would work best for the Screenshots team if changes to the slides were requested in GitHub issues: https://github.com/mozilla-services/screenshots/issues/new

To change Screenshots to highlight the page action at the appropriate time, I think it would be best if the Screenshots team could meet with an engineer who has been working on the onboarding. From there we can put together a quick implementation plan.
(In reply to Ian Bicking (:ianbicking) from comment #4)
> 
> It would work best for the Screenshots team if changes to the slides were
> requested in GitHub issues:
> https://github.com/mozilla-services/screenshots/issues/new
> 
Hi Ian - we don't want to change any of the slides.
Verdi, i think it would be a good idea to add a slide into our onboarding pointing to the page action since this will be unfamiliar to all users.
Flags: needinfo?(mverdi)
Similarly we will have full page shooting capability in the 57 version. We'd previously removed a slide for this when we took it out. I'd like to put it back in. Copy there has already been reviewed by michelle.
(In reply to [:jgruen] from comment #6)
> Verdi, i think it would be a good idea to add a slide into our onboarding
> pointing to the page action since this will be unfamiliar to all users.

Sorry - I meant, for the onboarding interaction, we don't require any additional slides. But yes, if you want to update the screenshots tour that's totally fine with us. :)
Flags: needinfo?(mverdi)
(In reply to Ian Bicking (:ianbicking) from comment #4)
> To change Screenshots to highlight the page action at the appropriate time,
> I think it would be best if the Screenshots team could meet with an engineer
> who has been working on the onboarding. From there we can put together a
> quick implementation plan.
Hi Ian,
After the bug 1390985, bug 1371543 and bug 1366041 get landed, to highlight the Screenshots page action button what https://screenshots.firefox.com have to do is:
1. Include the UITour lib[1] in the web page.
2. Call `Mozilla.UITour.showHighlight("screenshots")` at the appropriate timing to highlight the Screenshots page action button.

Please feel free to reach us for further discussion, thanks.

[1] http://searchfox.org/mozilla-central/source/browser/components/uitour/UITour-lib.js
Depends on: 1371543, 1390985, 1366041
(In reply to Ian Bicking (:ianbicking) from comment #4)
> The /#hello behavior was specifically designed for this kind of onboarding,
> so I think we should simply build off that.
> 
> Note the slides that are displayed are actually displayed by the add-on, and
> so they can display whatever is appropriate for that version. Technically it
> shouldn't be hard to trigger other behavior at that moment, such as
> highlighting the page action.
> 
> It would work best for the Screenshots team if changes to the slides were
> requested in GitHub issues:
> https://github.com/mozilla-services/screenshots/issues/new
> 
Hi Ian,
A issue submitted: https://github.com/mozilla-services/screenshots/issues/3411
Whiteboard: [photon-onboarding] → [photon-onboarding][triage]
Hi Fischer, i made a proposal doc for how this should work:

I've outlined my proposal in a g-doc i've shared, but i'll repeat the specifics in this bug as well:


1. Add screenshots.firefox.com to UItour whitelist. It looks like this work is already being done here: https://bugzilla.mozilla.org/show_bug.cgi?id=1371543

2. The screenshots site should trigger the desired uiTour event on visits to https://screenshots.firefox.com/#tour. This is tracked at: https://github.com/mozilla-services/screenshots/issues/3411

3. The Onboarding team should set the URL to which they send people as: https://screenshots.firefox.com/#tour to achieve their intended flow

4. When user clicks Firefox onboarding, they should be taken to https://screenshots.firefox.com/#tour and the UItour will trigger on the page action

5. Clicking the page action from /#tour  will launch the screenshots as usual. If the user has not taken our onboarding, they will be onboarded.

Issues are filed for steps 1 and 2, but we may need one more for step 3. I will be on late tonight so let me know if you have questions.
Flags: needinfo?(fliu)
Hi John, thanks for this clear flow update.
(In reply to [:jgruen] from comment #11)
> Hi Fischer, i made a proposal doc for how this should work:
> 
> I've outlined my proposal in a g-doc i've shared, but i'll repeat the
> specifics in this bug as well:
> 
> 1. Add screenshots.firefox.com to UItour whitelist. It looks like this work
> is already being done here:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1371543
> 
Yes, the bug 1371543 will add https://screenshots.firefox.com to UItour whitelist.

> 2. The screenshots site should trigger the desired uiTour event on visits to
> https://screenshots.firefox.com/#tour. This is tracked at:
> https://github.com/mozilla-services/screenshots/issues/3411
> 
> 3. The Onboarding team should set the URL to which they send people as:
> https://screenshots.firefox.com/#tour to achieve their intended flow
> 
> 4. When user clicks Firefox onboarding, they should be taken to
> https://screenshots.firefox.com/#tour and the UItour will trigger on the
> page action
> 
For the step 3 and 4, this is handled in the bug 1371538.
Thanks for this, will set the url to https://screenshots.firefox.com/#tour.

> 5. Clicking the page action from /#tour  will launch the screenshots as
> usual. If the user has not taken our onboarding, they will be onboarded.
> 
> Issues are filed for steps 1 and 2, but we may need one more for step 3. I
> will be on late tonight so let me know if you have questions.
Flags: needinfo?(fliu)
based on comment 10, already moved to github.
resolved invalid.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Whiteboard: [photon-onboarding][triage]
You need to log in before you can comment on or make changes to this bug.