Remove useless attributes for SourceBuffer.webidl

RESOLVED INVALID

Status

()

Core
Audio/Video: Playback
RESOLVED INVALID
4 months ago
4 months ago

People

(Reporter: alwu, Assigned: alwu)

Tracking

Other Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

According to [1], those comment could be removed, they're not the part of the source buffer.

[1] https://www.w3.org/TR/media-source/#sourcebuffer
Comment hidden (mozreview-request)

Comment 2

4 months ago
mozreview-review
Comment on attachment 8901014 [details]
Bug 1393669 - remove useless attributes of SourceBuffer.webidl.

https://reviewboard.mozilla.org/r/172482/#review177848

::: commit-message-39f53:5
(Diff revision 1)
> +Bug 1393669 - remove useless attributes of SourceBuffer.webidl.
> +
> +According to [1], those comment could be removed, they're not the part of the source buffer.
> +
> +[1] https://www.w3.org/TR/media-source/#sourcebuffer

Please don't use /TR/ specs, but the up-to-date specs, in this case
https://w3c.github.io/media-source/

::: dom/webidl/SourceBuffer.webidl
(Diff revision 1)
>    readonly attribute boolean updating;
>    [Throws]
>    readonly attribute TimeRanges buffered;
>    [SetterThrows]
>    attribute double timestampOffset;
> -  //readonly attribute AudioTrackList audioTracks;

I definitely see the following in the spec
    readonly attribute AudioTrackList      audioTracks;
    readonly attribute VideoTrackList      videoTracks;
    readonly attribute TextTrackList       textTracks;

::: dom/webidl/SourceBuffer.webidl
(Diff revision 1)
>    attribute EventHandler onabort;
>    [Throws]
>    void appendBuffer(ArrayBuffer data);
>    [Throws]
>    void appendBuffer(ArrayBufferView data);
> -  //[Throws]

This is fine.
Attachment #8901014 - Flags: review?(bugs) → review-
(In reply to Olli Pettay [:smaug] from comment #2)
> ::: commit-message-39f53:5
> (Diff revision 1)
> > +Bug 1393669 - remove useless attributes of SourceBuffer.webidl.
> > +
> > +According to [1], those comment could be removed, they're not the part of the source buffer.
> > +
> > +[1] https://www.w3.org/TR/media-source/#sourcebuffer
> 
> Please don't use /TR/ specs, but the up-to-date specs, in this case
> https://w3c.github.io/media-source/

What's the difference between TR and non-TR?
Because the left bar on the TR spec said that it's "W3C Recommendation", and the one in non-TR said that it's W3C "Editor's Draft".
Is the non-TR one always better than TR one?
Thanks!
Flags: needinfo?(bugs)

Comment 4

4 months ago
mozreview-review
Comment on attachment 8901014 [details]
Bug 1393669 - remove useless attributes of SourceBuffer.webidl.

https://reviewboard.mozilla.org/r/172482/#review177856

::: dom/webidl/SourceBuffer.webidl
(Diff revision 1)
>    readonly attribute boolean updating;
>    [Throws]
>    readonly attribute TimeRanges buffered;
>    [SetterThrows]
>    attribute double timestampOffset;
> -  //readonly attribute AudioTrackList audioTracks;

those aren't useless. they are valid attributes in the spec.

we don't do it at this stage (and we should).

So the comment "useless" isn't appropriate.

::: dom/webidl/SourceBuffer.webidl
(Diff revision 1)
>    [Throws]
>    void appendBuffer(ArrayBuffer data);
>    [Throws]
>    void appendBuffer(ArrayBufferView data);
> -  //[Throws]
> -  //void appendStream(Stream stream, [EnforceRange] optional unsigned long long maxSize);

this one got removed from the V1 spec, but there's strong push to re-add them in V2.
We didn't support Fetch Stream before, which is why we couldn't implement those specs.

Now we can
Attachment #8901014 - Flags: review?(jyavenard) → review-
(In reply to Alastor Wu [:alwu][please needinfo me][GMT+8] from comment #3)
> What's the difference between TR and non-TR?
TR is some old static version of the spec (may it called Recommendation or whatever), and non-TR is the up-to-date version including spec bug fixes etc.


In this case though it is not too clear which one is better since both are a bit old, from last November.
But in general non-TR should be newer.

Non-TR is basically Living Standard usually.
Flags: needinfo?(bugs)
According to the comment4, set it as INVALID.
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.