Closed Bug 1393681 Opened 7 years ago Closed 5 years ago

drop unnecessary arguments in Cocoa nsFilePicker functions

Categories

(Core :: Widget: Cocoa, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox57 --- wontfix
firefox68 --- fixed

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch fix v1.0 (obsolete) — Splinter Review
      No description provided.
Attachment #8901019 - Flags: review?(mstange)
Comment on attachment 8901019 [details] [diff] [review]
fix v1.0

Review of attachment 8901019 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay, I thought I had r+ed this patch long ago.
Attachment #8901019 - Flags: review?(mstange) → review+
Priority: -- → P3
Assignee: jaas → nobody

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jaas, could you have a look please?

Flags: needinfo?(jaas)

2 years, not 2 weeks...

Stephen, want to rebase this patch when you get a chance?

Flags: needinfo?(jaas) → needinfo?(spohl.mozilla.bugs)
Attached patch PatchSplinter Review

Updated patch for current trunk. Carrying over r+.

Attachment #8901019 - Attachment is obsolete: true
Flags: needinfo?(spohl.mozilla.bugs)
Attachment #9054696 - Flags: review+
Assignee: nobody → jaas
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: