1393690 - Upgrading and downgrading from ESR52 to nightly57 and back permanently disables addons

Status: RESOLVED INVALID

(Firefox :: Untriaged, defect)

Description

[tomi.pievilainen+mozilla]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170808215255

Steps to reproduce:

1. Install ESR 52 (52.3.0)
2. Install addons that are not supported in the new system or e10s (e.g. NoScript, Tab Groups, Vimperator, Zoom Page).
3. Launch the same profile with nightly
4. Launch the same profile again with ESR


Actual results:

All the addons are permanently disabled. The about:addons shows them grayed out with remove button, but no way to enable them. The dom for the page shows that the enable button has hidden="true".


Expected results:

There should be a way to use the old addons again.

There's a workaround by resetting all settings that begin with extensions.e10s* and restarting the ESR. Some of these settings seem to be introduced after the ESR (they disappear completely after resetting and restarting).

Comment 1

[Tooru Fujisawa [:arai]]

I've tried with NoScript, and I see the following error in browser console after step 4,
where {73a6fe31-595d-460b-a920-fcc0f8843232} is the uuid of NoScript.

1503646142641	addons.xpi-utils	WARN	Could not find source bundle for add-on {73a6fe31-595d-460b-a920-fcc0f8843232}: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFile.persistentDescriptor]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js :: this.XPIDatabase.parseDB :: line 673"  data: no] Stack trace: this.XPIDatabase.parseDB()@resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js:673 < this.XPIDatabase.syncLoadDB()@resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js:599 < this.XPIProvider.checkForChanges()@resource://gre/modules/addons/XPIProvider.jsm:3824 < this.XPIProvider.startup()@resource://gre/modules/addons/XPIProvider.jsm:2830 < callProvider()@resource://gre/modules/AddonManager.jsm:237 < _startProvider()@resource://gre/modules/AddonManager.jsm:790 < AddonManagerInternal.startup()@resource://gre/modules/AddonManager.jsm:976 < this.AddonManagerPrivate.startup()@resource://gre/modules/AddonManager.jsm:3033 < amManager.prototype.observe()@jar:file:///Applications/FirefoxESR52.app/Contents/Resources/omni.ja!/components/addonManager.js:65

I also see the similar error for all other system addons.

1503646142643	addons.xpi-utils	WARN	Could not find source bundle for add-on [e-mail]: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFile.persistentDescriptor]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js :: this.XPIDatabase.parseDB :: line 673"  data: no] Stack trace: this.XPIDatabase.parseDB()@resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js:673 < this.XPIDatabase.syncLoadDB()@resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js:599 < this.XPIProvider.checkForChanges()@resource://gre/modules/addons/XPIProvider.jsm:3824 < this.XPIProvider.startup()@resource://gre/modules/addons/XPIProvider.jsm:2830 < callProvider()@resource://gre/modules/AddonManager.jsm:237 < _startProvider()@resource://gre/modules/AddonManager.jsm:790 < AddonManagerInternal.startup()@resource://gre/modules/AddonManager.jsm:976 < this.AddonManagerPrivate.startup()@resource://gre/modules/AddonManager.jsm:3033 < amManager.prototype.observe()@jar:file:///Applications/FirefoxESR52.app/Contents/Resources/omni.ja!/components/addonManager.js:65

https://dxr.mozilla.org/mozilla-esr52/rev/6875875756ee1c8f645dcae37e545ff3bc70533a/toolkit/mozapps/extensions/internal/XPIProviderUtils.js#673

Comment 2

[Tooru Fujisawa [:arai]]

I've tried with 57.0a1 (2017-08-24) (64-bit) and 52.3.0 (64-bit) on macOS.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: browser console after step 4

here's the output of browser console after step 4
there are several errors and warnings

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: terminal output after step 4

and terminal output

Comment 5

[Tooru Fujisawa [:arai]]

the addons is disabled because of `appDisabled` property being true.
but `isUsableAddon(this)` returns true at the point of calling permissions function, from about:addons
  https://dxr.mozilla.org/mozilla-esr52/rev/6875875756ee1c8f645dcae37e545ff3bc70533a/toolkit/mozapps/extensions/internal/XPIProvider.jsm#7389

I'm not sure why `appDisabled` become true while startup...

Comment 6

[Kohei Yoshino [:kohei]]

Firefox 55 has changed the user profile format, no longer supports downgrades.

https://www.mozilla.org/en-US/firefox/55.0/releasenotes/