1393707 - mips performance segment fault

Status: RESOLVED INVALID

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Description

[qiaopengcheng]

Attachment: xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_mips64.S

User Agent: Mozilla/5.0 (X11; Linux mips64-loongson; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20170825111631

Steps to reproduce:

on mips64 platform, after starting performance for serveral minutes, firefox will crash for segment faults.


Actual results:

firefox crashed by segment faults.
including firefox45, firefox52, firefox57.......


Expected results:

Normal running.

Comment 1

[qiaopengcheng]

on mips64 platform, this file,

xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_mips64.S


has been modified for fixed the bug.

original code will generate a bug if interruption happens after line70(REG_L    sp, 0(sp)     # get orig sp back), the information saved on stack  maybe discard after interruption handler return.

Comment 2

[qiaopengcheng]

Attachment: fixed segment fault

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]: